ci: refresh Generate nyanlib caller from the centralized template

[jackgdsf]

The centralized reusable generate_nyanlib workflow now authenticates to GHCR with a GitHub App token rather than the job's GITHUB_TOKEN, so it needs GFP_GHCR_APP_ID and GFP_GHCR_APP_PRIVATE_KEY forwarded from the caller.

Refreshed straight from doplaydo/pdk-ci-workflow-public/templates, no manual edits:

• updated .github/workflows/generate_nyanlib.yml

pre-commit run --all-files run twice.

Test plan

• CI pre-commit job passes
• Generate nyanlib can pull the gfp-server image

Closes #342

Summary by Sourcery

Update the Generate nyanlib workflow caller to support GHCR authentication through the centralized reusable workflow.

Bug Fixes:

• Forward the GitHub App credentials required for the Generate nyanlib workflow to authenticate with GHCR.

CI:

• Refresh the Generate nyanlib caller workflow to pass the centralized workflow's GHCR authentication secrets.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refreshes the nyanlib workflow caller to pass the GitHub App credentials required by the centralized reusable workflow to authenticate against GHCR and pull the gfp-server image.

File-Level Changes

Change	Details	Files
Forward GitHub App credentials to the centralized nyanlib generation workflow for GHCR authentication.	Map the repository’s GHCR App ID secret into the reusable workflow. Map the repository’s GHCR App private key secret into the reusable workflow while retaining the existing API key forwarding.	.github/workflows/generate_nyanlib.yml

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#342	Refresh the repository's generate_nyanlib workflow caller to match the updated centralized reusable workflow.	✅
#342	Forward the GFP_GHCR_APP_ID and GFP_GHCR_APP_PRIVATE_KEY secrets from the caller so the reusable workflow can authenticate to GHCR and pull the gfp-server image across organizations.	✅

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Needs a human reviewer. The workflow will now pass a GitHub App private key and ID to the centralized reusable workflow; if that workflow handles or logs them incorrectly, the credential could be exposed or misused. Reverting stops future runs from receiving the secrets, but any exposure or access obtained before the revert would require credential rotation and would not be undone automatically.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}