chore: generate models.nyanlib and SVG symbols (cspdk--sample-projects/basic) - #345
Merged
Merged
Conversation
…s/basic) Adds the warm-start model cache and the rendered cell symbols for cspdk--sample-projects/basic. Generated with the same gfp engine calls the Generate nyanlib workflow makes, run locally because the workflow's gfp-server image pull is currently failing. Closes gdsfactory#344 Co-authored-by: Jonathan <86444011+thanojo@users.noreply.github.com> Co-Authored-By: Claude <noreply@anthropic.com>
jackgdsf
requested review from
MarkCunningham0410,
cdaunt,
joamatab and
thanojo
as code owners
September 4, 2026 11:07
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds locally generated build artifacts for cspdk--sample-projects/basic: a warm-start models.nyanlib cache and 165 rendered SVG cell symbols, produced through the same gfp generation flow as the workflow so the schematic editor can load models and symbols without resolving them from scratch. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
thanojo
enabled auto-merge
September 4, 2026 11:08
thanojo
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the warm-start model cache and rendered cell symbols for
cspdk--sample-projects/basic:cspdk--sample-projects/basic/build/models.nyanlib(337407 bytes)cspdk--sample-projects/basic/build/symbols/(165 SVGs)Generated with the same
gfpengine calls theGenerate nyanlibworkflow makes (gfp serve→listFactories→ batchedresolveFactorieswithrenderSymbols), run locally because the workflow'sgfp-serverimage pull from GHCR currently fails withdenied. Partial factory resolution is normal and matches what the workflow's own runs produce.These are generated artifacts, not authored code.
Test plan
Closes #344
Summary by Sourcery
Add generated model-cache and cell-symbol artifacts to the basic sample project.
New Features:
Chores: