Skip to content

chore: generate models.nyanlib and SVG symbols (cspdk--sample-projects/basic) - #345

Merged
thanojo merged 1 commit into
gdsfactory:mainfrom
jackgdsf:chore/update-nyanlib
Sep 4, 2026
Merged

thanojo merged 1 commit into
gdsfactory:mainfrom
jackgdsf:chore/update-nyanlib

Conversation

@jackgdsf

@jackgdsf jackgdsf commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Adds the warm-start model cache and rendered cell symbols for cspdk--sample-projects/basic:

  • cspdk--sample-projects/basic/build/models.nyanlib (337407 bytes)
  • cspdk--sample-projects/basic/build/symbols/ (165 SVGs)

Generated with the same gfp engine calls the Generate nyanlib workflow makes (gfp servelistFactories → batched resolveFactories with renderSymbols), run locally because the workflow's gfp-server image pull from GHCR currently fails with denied. Partial factory resolution is normal and matches what the workflow's own runs produce.

These are generated artifacts, not authored code.

Test plan

  • CI pre-commit job passes
  • Schematic editor picks up the warm-start cache

Closes #344

Summary by Sourcery

Add generated model-cache and cell-symbol artifacts to the basic sample project.

New Features:

  • Add a warm-start model cache for the basic sample project to improve schematic editor model availability.
  • Add rendered SVG cell symbols for the supported sample-project technologies and components.

Chores:

  • Commit the generated model and symbol artifacts for the basic sample project.

…s/basic)

Adds the warm-start model cache and the rendered cell symbols for
cspdk--sample-projects/basic. Generated with the same gfp engine calls the
Generate nyanlib workflow makes, run locally because the workflow's
gfp-server image pull is currently failing.

Closes gdsfactory#344

Co-authored-by: Jonathan <86444011+thanojo@users.noreply.github.com>
Co-Authored-By: Claude <noreply@anthropic.com>
@sourcery-ai

sourcery-ai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds locally generated build artifacts for cspdk--sample-projects/basic: a warm-start models.nyanlib cache and 165 rendered SVG cell symbols, produced through the same gfp generation flow as the workflow so the schematic editor can load models and symbols without resolving them from scratch.

File-Level Changes

Change Details Files
Add a generated warm-start model cache for the basic sample project.
  • Add the generated models.nyanlib artifact containing partially resolved factory/model data.
  • Generate the cache using the same gfp server, factory listing, batched resolution, and symbol-rendering flow used by the workflow, executed locally due to the GHCR image pull issue.
cspdk--sample-projects/basic/build/models.nyanlib
Add rendered SVG cell symbols for the sample project's supported PDK factories.
  • Add 165 generated SVG symbols covering the cspdk, si220 C/ O-band, si340, si500, si_sus, sin200, and sin300 libraries.
  • Include symbols for common waveguides, bends, couplers, gratings, heaters, MMIs, rings, spirals, tapers, dies, pads, vias, and related cells.
cspdk--sample-projects/basic/build/symbols/

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@thanojo
thanojo enabled auto-merge September 4, 2026 11:08
@thanojo
thanojo merged commit 0ee88e7 into gdsfactory:main Sep 4, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate the models.nyanlib warm-start cache and SVG symbols

2 participants