feat(schematic): annotate die_with_pads as a type:die component - #351
Open
pepijndevos wants to merge 1 commit into
Open
feat(schematic): annotate die_with_pads as a type:die component#351pepijndevos wants to merge 1 commit into
pepijndevos wants to merge 1 commit into
Conversation
die_with_pads instances are oversized and unsuitable for schematic rendering, so editors need to treat them as dies rather than generic circuit boxes. Annotate the factory with a schematic_function whose symbol is "die" in both si220 bands. The port list is derived from the factory kwargs (ngratings, npads, with_loopback, grating_coupler) rather than a frozen default-parameter snapshot, so parameterized metadata resolution stays port-true once dynamic-port support lands. Each declared side is the die edge the port sits on — the opposite of the port's GDS orientation, which points into the die — ordered clockwise to match the nyanlib-to-Mosaic bridge. Verified the annotation against built cells in both bands for default and non-default parameters. Depends on doplaydo/gdsfactoryplus#4402 for type:"die" rendering support.
Reviewer's GuideAnnotates both C-band and O-band File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
pepijndevos
marked this pull request as ready for review
September 11, 2026 11:49
pepijndevos
requested review from
MarkCunningham0410,
cdaunt,
joamatab and
thanojo
as code owners
September 11, 2026 11:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
die_with_padsinsi220/cbandandsi220/obandnow carries a schematic annotation withsymbol: "die", so editors render it as a die component (no background box, port labels outside the symbol) instead of a generic circuit box.ngratings,npads,with_loopback,grating_coupler— through a new callable-ports option on the sharedschematic()helper, instead of a static default-parameter snapshot. When GFP resolves schematic metadata per parameterization (dynamic-port support, doplaydo/gdsfactoryplus#3886), this annotation is already parameter-true.ngratings-2ports are exposed per W/E edge whenwith_loopbackis set;npadspads per N/S edge.grating_coupler=Nonedrops the photonic ports entirely.Dependency
Requires doplaydo/gdsfactoryplus#4402 for
type: "die"rendering support in Mosaic/nyanlib.Verification
Annotation output was compared against built cells in both bands — names, sides, and per-side clockwise order match exactly:
ngratings=10, npads=5ngratings=5, npads=3, with_loopback=Falsegrating_coupler=Nonengratings=12, npads=7Summary by Sourcery
Render parameterized SI220
die_with_padscomponents as die symbols with ports that accurately reflect their configured pads, gratings, and loopback connections.New Features:
die_with_padscomponents in both SI220 bands with die-specific schematic symbols and parameter-dependent photonic and electrical ports.Enhancements: