Skip to content

core-extraction: buildJsonReport's dailyMap fallback is unreachable dead code #1067

Description

@iamtoruk

Found during #929 review: buildJsonReport in packages/cli/src/main.ts takes durable from both call sites unconditionally (buildDurablePeriod() never returns null), so the dailyMap fallback branch (~30 lines) can never execute and cannot be covered by any test from any entry point. #929 originally patched this dead branch for the midnight-straddle rule; the hunk was dropped as unreachable. Follow-up: make durable a required parameter and delete the fallback branch (tsc + suite will prove nothing depends on it), or document why the fallback stays.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions