Remove skipAutoLogout mechanism

[matthew-white]

Frontend has a route meta field called skipAutoLogout. It is described as follows here:

If true, no alert will be displayed when session is about to expire. Also user will be not be redirected to login page when session has expired.

This was useful when submissions were filled out within Central Frontend, i.e., when Central rendered the Web Forms component, before the addition of the separate Web Forms app. Given the new Web Forms app, I don't think this skipAutoLogout mechanism is used anymore on any of the remaining Central pages.

Given that the mechanism isn't used anymore, I think we can remove it from Frontend. Doing so would reduce code complexity related to login/logout.

[matthew-white]

CC @sadiqkhoja. Does it sound right to you that we can remove the skipAutoLogout mechanism and that nothing is using it anymore?

[sadiqkhoja]

that's sound right to me. But I would like @garethbowen / @latin-panda to confirm that following case is handled in the web-form app:

• Data collector is filling up a new Form and left the tab opened for more than 24 hours
• Clicks the submit button (session is expired)
• Sees a dialog that session is expired and option to login in another tab
• Logs in another tab, comes back to original tab and submits again

[garethbowen]

@sadiqkhoja Yes that is designed to just work. Session expiry is detected on submit pops a dialog so the form content isn't lost, and the user can re-send once the session is re-established. There's a e2e test that asserts this, albeit with an explicit log out rather than a session timeout: https://github.com/getodk/central-frontend/blob/c19a53bcc1680d9f8fa5d58a874f4c8a4cabb597/e2e-tests/tests/web-forms.spec.js#L155