Repository navigation
fix(deps): Treat ambiguous slash extglobs as risky in picomatch patch - #983
Merged
Merged
Conversation
The slash exemption kept the repetition for any single-branch body with a literal slash. A globstar crosses the slash (+(**/a)), and two stars in one path segment split ambiguously across repeats (+(*/*)), so both still backtracked exponentially. Keep the repetition only when every path segment, including the one shared by adjacent repeats, holds at most one star.
Contributor
|
BYK
approved these changes
Nov 18, 2026
8 tasks done
sentry-junior Bot
added a commit
to getsentry/junior
that referenced
this pull request
Nov 21, 2026
The watched-merge case names getsentry/craft#983. The shared GitHub HTTP fixture now serves it merged, with no Dependabot alerts, so a lookup in a live run gets data instead of an unhandled-request error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local picomatch patches from #982 for GHSA-fc5q-39xc-vjpf keep the repetition of any single-branch extglob with a literal
/. They assume the slash fixes where each repeat starts. Two shapes break that and still backtrack exponentially:+(**/a): a globstar crosses/.+(*/*): one repeat's trailing*and the next repeat's leading*share a path segment, so every segment can split two ways.Now a slash body keeps its repetition only when it has no globstar and every path segment holds at most one
*, counting the segment shared across repeats. Globs like+(src/*/)and+(src/*/*.js)match as before.+(**/a),+(*/*)and+(*a/*)are literalized, like the other risky extglobs. The change covers the 4.0.7 and 2.3.2 patches in root anddocs/.via @BYK.
--
View Session [Sentry]