Repository navigation
ci: treat warnings as errors - #181
Merged
Merged
Conversation
jpnurmi
force-pushed
the
jpnurmi/ci/error-on-warnings
branch
from
November 18, 2026 15:48
444b190 to
8cb025c
Compare
jpnurmi
force-pushed
the
jpnurmi/ci/error-on-warnings
branch
from
November 20, 2026 09:14
8cb025c to
817cfb8
Compare
Stop forcing `/WX` on users who build crashpad, so that new compiler warnings do not break their builds. CI enables `CMAKE_COMPILE_WARNING_AS_ERROR` instead to keep the code free of warnings. Build with `-Wall` on non-MSVC compilers to match `/W4` on MSVC.
- `-Wdangling-else` in `ZlibOutputStream` - `-Wrestrict` from passing the same `stack_t` to `sigaltstack()` - `-Wclass-memaccess` from clearing `SettingsReader::Data` - `-Wreorder-ctor` in `ProcessReaderMac` - ARC bridging casts in `on_demand_service_tool` - deprecated `unlink()` in `crashpad_generate_dump` with clang-cl
MinGW ignores `#pragma section` and `__declspec(allocate)`, so the handler could not find `CrashpadInfo` and ignored its settings, such as `limit_stack_capture_to_sp`. Use the GNU `section` attribute instead.
jpnurmi
force-pushed
the
jpnurmi/ci/error-on-warnings
branch
from
November 20, 2026 09:39
817cfb8 to
ce3b331
Compare
The arm64 assembly is preprocessed as C, where the definition
redefines a builtin macro:
<command line>:11:9: error: redefining builtin macro [-Werror,-Wbuiltin-macro-redefined]
Ref: https://github.com/getsentry/crashpad/actions/runs/44712564858/job/136207676046
JoshuaMoelans
approved these changes
Nov 20, 2026
jpnurmi
added a commit
to getsentry/sentry-native
that referenced
this pull request
Nov 20, 2026
Bump to the merge commits of getsentry/breakpad#47 and getsentry/crashpad#181.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop forcing
/WXon users who include crashpad in their builds, so that new compiler warnings do not break their builds. CI enablesCMAKE_COMPILE_WARNING_AS_ERRORinstead to keep the code free of warnings.Build with
-Wallon non-MSVC compilers to match/W4on MSVC, and fix the resulting warnings:GCC:
macOS:
clang-cl:
MinGW:
MinGW arm64 (
util/misc/capture_context_win_arm64.S):The vendored libunwind in the macOS stack-trace build is excluded from warnings as errors: