Repository navigation
docs(develop): Broaden no_parent_span client report reason - #20572
Closed
sentry-junior[bot] wants to merge 2 commits into
Closed
sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
|
Getting ready to monitor this change · Rollout details
|
Member
|
@Lms24 convinced me that this is not a good idea, and that we should instead use |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Broadens the
no_parent_spandiscard reason to also cover spans that are dropped at span end. The case that prompted this: transaction-based SDKs drop child spans that finish after their transaction was sent. No existing reason fits that case, and SDKs currently handle it differently (JS usesinvalid, Python usesbuffer_overflow). We discussed this in the SDK team channel.New wording: "Span was not started or was dropped because no active parent span or transaction was present at span start or end."
The wording only describes why a span was dropped. It doesn't imply that every span without a parent gets dropped (in span streaming, spans without a parent become segments). The reason is already registered in Snuba and the frontend, so only the spec needs to change. This bumps the spec to
1.26.0and sets the discard-reasons section'ssinceto1.26.0, following the spec lifecycle.This replaces #20571, which stopped picking up new pushes to its branch.
Refs getsentry/sentry-rust#1397
IS YOUR CHANGE URGENT?
PRE-MERGE CHECKLIST
via @szokeasaurusrex.
--
View Session [Sentry]