Repository navigation
docs(develop): Broaden invalid client report reason - #20595
Merged
szokeasaurusrex merged 2 commits intoNov 10, 2026
Merged
Conversation
Co-Authored-By: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
|
Getting ready to monitor this change · Rollout details
|
Lms24
approved these changes
Nov 6, 2026
sentrivana
approved these changes
Nov 6, 2026
szokeasaurusrex
deleted the
szokeasaurusrex/broaden-invalid-discard-reason
branch
November 10, 2026 12:17
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Broadens the
invaliddiscard reason to cover any data that is dropped because it is invalid, including data in an invalid SDK state, not only data that fails validation. It applies only when no more specific reason fits.The case that prompted this: transaction-based SDKs drop child spans that finish after their transaction was sent. A child span can't outlive its transaction, so the span is invalid, but it didn't strictly "fail validation." JS already reports this case as
invalid. We discussed this in the SDK team channel.New wording: "Telemetry item failed validation or was otherwise invalid, and no more specific reason applies."
The reason is already registered, so this only changes the spec. This bumps the spec to
1.26.0and sets the discard-reasons section'ssinceto1.26.0, following the spec lifecycle.Refs getsentry/sentry-rust#1397
IS YOUR CHANGE URGENT?
PRE-MERGE CHECKLIST
via @szokeasaurusrex.
--
View Session [Sentry]