Repository navigation
ci: Add a single Required checks job for the branch ruleset - #146
Merged
Merged
Conversation
Co-Authored-By: Armen Zambrano Gasparnian <44410+armenzg@users.noreply.github.com>
armenzg
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing stops a PR from merging before CI finishes. #138 merged while
Pre-commit checkswas still running.This adds a
Required checksjob that waits forDocker build,Unit tests,Type checksandPre-commit checks. It fails unless all four succeeded, and it still runs (and fails) when one of them fails or gets cancelled. A branch ruleset onmaincan then require just this one check. Adding or renaming a job later only means updating itsneedslist, not the ruleset.The
pull_requesttrigger no longer skips PRs that only change**.mdfiles. With that filter, a docs-only PR would never get the required check and would wait forever. Thepushfilter stays as it is.This does nothing by itself. Someone with admin on the repo has to create the ruleset after this merges: target the default branch, require the
Required checksstatus check, and leave the bypass list empty.via @armenzg.
--
View Session [Sentry]