Skip to content

ci: Add a single Required checks job for the branch ruleset - #146

Merged
armenzg merged 1 commit into
mainfrom
ci/required-checks-job
Nov 5, 2026
Merged

armenzg merged 1 commit into
mainfrom
ci/required-checks-job

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Nothing stops a PR from merging before CI finishes. #138 merged while Pre-commit checks was still running.

This adds a Required checks job that waits for Docker build, Unit tests, Type checks and Pre-commit checks. It fails unless all four succeeded, and it still runs (and fails) when one of them fails or gets cancelled. A branch ruleset on main can then require just this one check. Adding or renaming a job later only means updating its needs list, not the ruleset.

The pull_request trigger no longer skips PRs that only change **.md files. With that filter, a docs-only PR would never get the required check and would wait forever. The push filter stays as it is.

This does nothing by itself. Someone with admin on the repo has to create the ruleset after this merges: target the default branch, require the Required checks status check, and leave the bypass list empty.

via @armenzg.

--

View Session [Sentry]

Co-Authored-By: Armen Zambrano Gasparnian <44410+armenzg@users.noreply.github.com>
@armenzg
armenzg marked this pull request as ready for review November 5, 2026 19:34
@armenzg
armenzg requested a review from a team as a code owner November 5, 2026 19:34
@armenzg
armenzg merged commit e152411 into main Nov 5, 2026
16 checks passed
@armenzg
armenzg deleted the ci/required-checks-job branch November 5, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant