Skip to content

ci(docker): Don't block merges on the image vulnerability scan - #165

Merged
armenzg merged 1 commit into
mainfrom
ci/nonblocking-image-scan
Nov 9, 2026
Merged

armenzg merged 1 commit into
mainfrom
ci/nonblocking-image-scan

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

The Grype scan ran inside Docker build, which Required checks depends on. So when a new CVE shows up in the base image, every PR fails, even ones that don't touch the image. That's happening now with zlib1g in python:3.15.2-slim (see #164).

This moves the scan into its own Image vulnerability scan job and leaves it out of Required checks. It still runs on every PR and push to main and shows as a failed check, so findings stay visible, but they no longer block merges. The scan settings (only-fixed, severity-cutoff: high) are unchanged.

The new job builds the image again, since jobs don't share a Docker daemon. It reads the layer cache that Docker build writes, but doesn't write to it, so the two jobs don't race on the cache. Docker build keeps the build and the startup check.

via @armenzg.

via @armenzg.

--

View Session [Sentry]

Co-Authored-By: Armen Zambrano Gasparnian <44410+armenzg@users.noreply.github.com>
@armenzg
armenzg marked this pull request as ready for review November 9, 2026 13:54
@armenzg
armenzg requested a review from a team as a code owner November 9, 2026 13:54
@armenzg armenzg closed this Nov 9, 2026
@armenzg armenzg reopened this Nov 9, 2026
@armenzg
armenzg enabled auto-merge (squash) November 9, 2026 13:57
@armenzg
armenzg merged commit 076f514 into main Nov 9, 2026
26 of 28 checks passed
@armenzg
armenzg deleted the ci/nonblocking-image-scan branch November 9, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant