Repository navigation
test(e2e): Run express-5 on Bun, Deno and Cloudflare - #26561
Merged
Merged
Conversation
Contributor
size-limit report 📦Compared: d821047 (PR test merge using develop at d8564c0) Against: d8564c0 (develop) · base run #67328 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 7 not successful, 56 successful. See the run.
Successful checks
|
JPeer264
force-pushed
the
jp/express-e2e-runtime-matrix
branch
from
November 19, 2026 09:51
fac5278 to
1888947
Compare
Base automatically changed from
jp/express-late-registration-events
to
develop
November 19, 2026 09:59
JPeer264
force-pushed
the
jp/express-e2e-runtime-matrix
branch
2 times, most recently
from
November 20, 2026 12:54
271954d to
104d68f
Compare
JPeer264
marked this pull request as ready for review
November 20, 2026 13:34
javascript-sdk-gitflow
Bot
requested review from
andreiborza,
isaacs and
msonnb
November 20, 2026 13:34
Renames `node-express-v5` to `express-5` and adds optional Bun, Deno and Cloudflare variants next to the required Node job. Each runtime inits its own SDK, and the app reads the Sentry API from `src/sentry.ts`, which each variant replaces with its SDK. - Node still runs the CommonJS build. `src/main.ts` is the entry now, so that the Worker can import the app without the Node init. - Bun bundles `src/main.ts` with `@sentry/bun/plugin`. - Deno runs the TypeScript sources with `--preload=@sentry/deno/import`. - Cloudflare builds with Vite and `sentryCloudflareVitePlugin`. The app registers its routes at module scope, like the Express docs show. New tests cover parameterized route names, per-request isolation, incoming trace continuation and outgoing `fetch` propagation. They pass on all four runtimes without a `RUNTIME` branch. Tests that branch on `RUNTIME`: - Local variables and the Node runtime metrics run on Node only. - The MCP SSE transport is skipped on Cloudflare. workerd cancels the write to the response of another request, also without Sentry. - The `http.server` span has no `http.response.status_text` on Bun, and comes from the Worker `Request` on Cloudflare. The MySQL route opens its connection in the request, because on Cloudflare a socket only works in the request that opened it. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/express-e2e-runtime-matrix
branch
from
November 20, 2026 13:35
b9a3d2d to
c2c8167
Compare
msonnb
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #24845
closes JS-3846
Description
This renames the e2e app
node-express-v5toexpress-5and runs its suite on Bun, Deno and Cloudflare as optional variants, next to the required Node job. Each runtime inits its own SDK, and the app reads the Sentry API fromsrc/sentry.ts, which each variant replaces with its SDK.New tests cover parameterized route names, per-request isolation, incoming trace continuation and outgoing
fetchpropagation. They pass on all four runtimes without aRUNTIMEbranch.Known issues
http.serverspan has nohttp.response.status_texton Bun and on Cloudflare, and nosentry.kindon Cloudflare. The tests branch onRUNTIMEthere.