Repository navigation
test(e2e): Pin GraphQL delegate in Hydrogen apps - #26706
Closed
nicohrubec wants to merge 1 commit into
Closed
nicohrubec wants to merge 1 commit into
nicohrubec wants to merge 1 commit into
Conversation
Pin the v12 dependency to 12.3.4 after both CI app installs received a 404 for the 12.3.5 tarball. Co-Authored-By: Codex <codex@openai.com>
andreiborza
approved these changes
Nov 20, 2026
andreiborza
left a comment
Member
There was a problem hiding this comment.
Is this something that needs a fix upstream? If so, please also open a draft PR to unpin this, otherwise we'll forget.
msonnb
approved these changes
Nov 20, 2026
Contributor
size-limit report 📦Compared: 4fb2cf7 (PR test merge using develop at bd2d389) Against: 1013ef9 (develop) · base run #67306
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin the v12 line of
@graphql-tools/delegateto12.3.4in the Hydrogen React Router and Remix Hydrogen E2E apps.Why
Both CI app installs received an HTTP 404 for the
12.3.5tarball. Pinning the previous patch avoids resolving that version while preserving older transitive major versions. Both apps install and build successfully with the pin.