Skip to content

feat(internal): thread pool - #1883

Open
jpnurmi wants to merge 15 commits into
masterfrom
jpnurmi/perf/thread-pool
Open

feat(internal): thread pool#1883
jpnurmi wants to merge 15 commits into
masterfrom
jpnurmi/perf/thread-pool

Conversation

@jpnurmi

@jpnurmi jpnurmi commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Introduce a generic thread pool that runs tasks in parallel in a predetermined number of pooled threads and invokes completion callbacks in submission order. The primary use case is the telemetry serialization pool coming in #1946, but it could be used for offloading other heavy tasks, too.

#skip-changelog (internal)

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 6ca0dce

Comment thread src/sentry_telemetry.c
Comment thread src/sentry_batcher.c Outdated
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.94574% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.08%. Comparing base (219d934) to head (6ca0dce).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1883      +/-   ##
==========================================
+ Coverage   76.01%   76.08%   +0.07%     
==========================================
  Files          94       94              
  Lines       22183    22441     +258     
  Branches     3937     4017      +80     
==========================================
+ Hits        16863    17075     +212     
- Misses       4436     4468      +32     
- Partials      884      898      +14     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/thread-pool branch from 2996a56 to ec39dc8 Compare July 22, 2026 14:55
Comment thread src/backends/sentry_backend_inproc.c
Comment thread src/sentry_batcher.c Outdated
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/thread-pool branch from ec39dc8 to 829189b Compare July 22, 2026 15:14
Comment thread src/backends/sentry_backend_breakpad.cpp
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/thread-pool branch from 829189b to 406b054 Compare July 22, 2026 15:47
Comment thread src/sentry_batcher.c Outdated
Comment thread src/sentry_telemetry.c Outdated
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/thread-pool branch from 406b054 to 03159d6 Compare July 22, 2026 16:02
Comment thread src/sentry_batcher.c Outdated
Comment thread src/sentry_batcher.c Outdated
Comment thread src/sentry_transport.c
Comment thread src/sentry_telemetry.c Outdated
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/thread-pool branch from e417bed to 12f4872 Compare July 24, 2026 10:19
Comment thread src/sentry_telemetry.c Outdated
Comment thread src/sentry_batcher.c Outdated
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/thread-pool branch 4 times, most recently from 33f0d1a to d39154d Compare August 3, 2026 08:43
@jpnurmi
jpnurmi changed the base branch from master to jpnurmi/ref/transport-crash-dump August 3, 2026 08:55
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/thread-pool branch from d39154d to 9dee343 Compare August 3, 2026 09:39
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/thread-pool branch 2 times, most recently from 265b68d to 8c2f921 Compare August 3, 2026 12:53
@jpnurmi
jpnurmi changed the base branch from master to jpnurmi/feat/cond-wake-all August 6, 2026 07:45
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/thread-pool branch from e5f725b to b555546 Compare August 6, 2026 08:16
Comment thread src/sentry_sync.c
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/thread-pool branch from b555546 to b4c5eb3 Compare August 6, 2026 08:59

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b4c5eb3. Configure here.

Comment thread src/sentry_sync.c
Base automatically changed from jpnurmi/feat/cond-wake-all to master August 6, 2026 09:45
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/thread-pool branch from 8b1166d to 3c6b937 Compare August 6, 2026 09:45
Comment thread src/sentry_sync.c
Comment thread tests/unit/test_sync.c
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/thread-pool branch from 21b6f50 to 143a50b Compare August 6, 2026 10:54
@jpnurmi
jpnurmi changed the base branch from master to jpnurmi/ref/spinlock August 6, 2026 11:10
@jpnurmi
jpnurmi requested a review from JoshuaMoelans August 6, 2026 11:54
Base automatically changed from jpnurmi/ref/spinlock to master August 6, 2026 14:45
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/thread-pool branch from 143a50b to 6ca0dce Compare August 6, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant