Skip to content

feat(data-collection): gate HTTP request data collection#6678

Draft
ericapisani wants to merge 1 commit into
ep/db-spec-experiment-foundationfrom
ep/db-spec-experiment-http
Draft

feat(data-collection): gate HTTP request data collection#6678
ericapisani wants to merge 1 commit into
ep/db-spec-experiment-foundationfrom
ep/db-spec-experiment-http

Conversation

@ericapisani

Copy link
Copy Markdown
Member

Part of the data_collection split — depends on #6676 (foundation).

Gates HTTP request data (headers, cookies, query params, bodies, user identity/IP) across all web + serverless integrations via the foundation's key-value collection helpers.

@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

88641 passed | ❌ 3 failed | ⏭️ 5890 skipped | Total: 94534 | Pass Rate: 93.77% | Execution Time: 320m 18s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -1922
Passed Tests 📉 -1510
Failed Tests 📈 +3
Skipped Tests 📉 -415

➕ New Tests (3)

View new tests
  • test_embeddings_create_with_list_input[False-False]
    • File: tests.integrations.litellm.test_litellm
    • Status: ❌ Failing
  • test_cache_spans_get_span_name[True-get-args4-kwargs4-]
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing
  • test_cache_spans_get_span_name[False-get-args4-kwargs4-]
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing

❌ Failed Tests

test_embeddings_create_with_list_input[False-False]

File: tests.integrations.litellm.test_litellm
Suite: py3.12-litellm-v1.77.7
Error: assert 0 == 1 + where 0 = len([])

Stack Trace
tests/integrations/litellm/test_litellm.py:1031: in test_embeddings_create_with_list_input
    assert len(spans) == 1
E   assert 0 == 1
E    +  where 0 = len([])

test_cache_spans_get_span_name[True-get-args4-kwargs4-]

File: tests.integrations.django.test_cache_module
Suite: py3.14-django-v6.1a1
Error: AssertionError: assert '\Oy\r2\x03A鑮ɔp2Xr' == '' + \Oy + 2#x03A鑮ɔp2Xr

Stack Trace
tests/integrations/django/test_cache_module.py:578: in test_cache_spans_get_span_name
    assert _get_span_description(method_name, args, kwargs) == expected_name
E   AssertionError: assert '\\Oy\r2\x03A鑮ɔp2Xr' == ''
E     
E     + \Oy
E     + 2#x03A鑮ɔp2Xr

test_cache_spans_get_span_name[False-get-args4-kwargs4-]

File: tests.integrations.django.test_cache_module
Suite: py3.14-django-v6.1a1
Error: AssertionError: assert '\Oy\r2\x03A鑮ɔp2Xr' == '' + \Oy + 2#x03A鑮ɔp2Xr

Stack Trace
tests/integrations/django/test_cache_module.py:578: in test_cache_spans_get_span_name
    assert _get_span_description(method_name, args, kwargs) == expected_name
E   AssertionError: assert '\\Oy\r2\x03A鑮ɔp2Xr' == ''
E     
E     + \Oy
E     + 2#x03A鑮ɔp2Xr

❌ Patch coverage is 68.29%. Project has 2486 uncovered lines.
❌ Project coverage is 89.7%. Comparing base (base) to head (head).

Files with missing lines (13)
File Patch % Lines
sentry_sdk/integrations/_asgi_common.py 47.83% ⚠️ 12 Missing and 2 partials
sentry_sdk/integrations/_wsgi_common.py 77.42% ⚠️ 7 Missing and 6 partials
sentry_sdk/integrations/aws_lambda.py 33.33% ⚠️ 10 Missing and 2 partials
sentry_sdk/integrations/gcp.py 15.38% ⚠️ 11 Missing
sentry_sdk/integrations/starlette.py 69.23% ⚠️ 4 Missing and 3 partials
sentry_sdk/integrations/aiohttp.py 85.00% ⚠️ 3 Missing and 2 partials
sentry_sdk/integrations/fastapi.py 75.00% ⚠️ 2 Missing and 2 partials
sentry_sdk/integrations/quart.py 81.25% ⚠️ 3 Missing and 1 partials
sentry_sdk/integrations/sanic.py 70.00% ⚠️ 3 Missing and 1 partials
sentry_sdk/integrations/tornado.py 72.73% ⚠️ 3 Missing and 1 partials
sentry_sdk/integrations/wsgi.py 81.25% ⚠️ 3 Missing and 1 partials
sentry_sdk/integrations/litestar.py 75.00% ⚠️ 2 Missing and 1 partials
sentry_sdk/integrations/starlite.py 75.00% ⚠️ 2 Missing and 1 partials
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    89.92%    89.70%    -0.22%
==========================================
  Files          192       193        +1
  Lines        23809     24137      +328
  Branches      8218      8396      +178
==========================================
+ Hits         21409     21651      +242
- Misses        2400      2486       +86
- Partials      1339      1378       +39

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant