Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
f344f95
feat(issues): Add native stack trace component
scttcper Apr 25, 2026
3f44186
add display dropdown specific to native
scttcper Apr 27, 2026
1494a6e
Merge branch 'master' into scttcper/native-stack-trace
scttcper May 18, 2026
41c157b
feat(stacktrace): Persist native display options
scttcper May 18, 2026
44f4d0f
feat(issues): Add native threaded stack trace
scttcper May 18, 2026
ef3d67d
fix(issues): Tighten native frame header layout
scttcper May 19, 2026
82bd40b
make sure character is not clipped
scttcper May 19, 2026
7abb725
Merge remote-tracking branch 'origin/master' into scttcper/native-sta…
scttcper May 29, 2026
e5e76ab
fix(issues): Load raw native crash reports
scttcper May 29, 2026
c03a7d5
fix(issues): Fill native stack trace parity gaps
scttcper May 29, 2026
8adad86
fix(issues): Hide Dart async native frames
scttcper May 29, 2026
896dc8a
fix(issues): Match native lead hint visibility
scttcper May 29, 2026
12e1afe
fix(issues): Restore native hidden frame styling
scttcper May 29, 2026
88767b5
fix(issues): Show native grouping markers by default
scttcper May 29, 2026
43a4a46
fix(issues): Match native verbose function display
scttcper May 29, 2026
86b2932
fix(issues): Match native stack trace behavior
scttcper May 29, 2026
f8b2828
fix(issues): Show git provider banner for native exceptions
scttcper May 29, 2026
37bd4ac
ref(issues): Use React state for native thread selection
scttcper May 29, 2026
e836ec0
ref(issues): Simplify native thread stack trace context
scttcper May 29, 2026
804ce63
ref(issues): Simplify native frame status handling
scttcper May 29, 2026
173e943
knip
scttcper May 29, 2026
9c3346d
smaller breakpoint
scttcper May 29, 2026
7714792
Merge branch 'master' of https://github.com/getsentry/sentry into sct…
scttcper Jun 3, 2026
970a542
Merge branch 'master' into scttcper/native-stack-trace
scttcper Jun 22, 2026
9aff59f
fix(issues): Restore native thread stack trace parity
scttcper Jun 22, 2026
87ce0e6
knip
scttcper Jun 22, 2026
e881a14
chore(stacktrace): Merge master into native stack trace
scttcper Jul 31, 2026
ee98fca
feat(stacktrace): Add native stack trace previews
scttcper Jul 31, 2026
6784506
fix(stacktrace): Isolate native stack trace state
scttcper Jul 31, 2026
8b58bd7
ref(stacktrace): Use React 19 context providers
scttcper Jul 31, 2026
cbbf12a
chore(issues): Merge master into native stack trace branch
scttcper Sep 10, 2026
466c247
fix(issues): Preserve native stack trace display behavior
scttcper Sep 10, 2026
4e90043
ref(issues): Simplify native stack trace components
scttcper Sep 10, 2026
677e609
ref(issues): Scope native stack providers to trace content
scttcper Sep 10, 2026
b28b87e
feat(issues): Cover native exceptions and standalone stacks
scttcper Sep 10, 2026
d73c8b9
test(issues): Fix native stack trace CI checks
scttcper Sep 10, 2026
1326d2d
chore: Merge latest master
scttcper Oct 1, 2026
add8fc6
fix(issues): Port native stack trace updates
scttcper Oct 1, 2026
5bf395b
style(issues): Combine native stack trace imports
scttcper Oct 1, 2026
e2cbdc1
test(issues): Wait for native stack trace source links
scttcper Oct 1, 2026
c08dce6
fix(issues): Restore native stack trace desktop breakpoint
scttcper Oct 2, 2026
5bd4cba
ref(issues): Simplify native stack trace rendering
scttcper Oct 2, 2026
e14d7a6
Merge remote-tracking branch 'origin/master' into scttcper/native-sta…
scttcper Oct 5, 2026
fb1198d
fix(issues): Pair copied native thread exceptions, review cleanups
scttcper Oct 5, 2026
9aa0fe0
ref(issues): Shrink native stack trace components
scttcper Oct 5, 2026
7637e16
fix(issues): Stack native frames in narrow containers
scttcper Oct 7, 2026
f92f34c
Merge branch 'master' into scttcper/native-stack-trace
scttcper Oct 7, 2026
29b8ec9
ref(issues): Use layout primitives for chevron slot and preview message
scttcper Oct 7, 2026
8e5c641
Merge branch 'master' into scttcper/native-stack-trace
scttcper Oct 13, 2026
cb1027f
perf(issues): Memoize stack trace row policy
scttcper Oct 13, 2026
7cd7d82
chore(issues): Merge master into native stack trace branch
scttcper Oct 22, 2026
b42f6b8
fix(issues): Port native stack trace updates
scttcper Oct 22, 2026
c560c3a
Merge branch 'master' into scttcper/native-stack-trace
scttcper Nov 20, 2026
be3bc40
fix(issues): Catch native stack trace up with the legacy one
scttcper Nov 21, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 56 additions & 15 deletions static/app/components/events/eventStackTrace.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,16 @@ import {Fragment, useMemo} from 'react';

import {IssueStackTrace} from 'sentry/components/stackTrace/issueStackTrace';
import {getOrderedExceptions} from 'sentry/components/stackTrace/issueStackTrace/utils';
import {IssueThreadStackTrace} from 'sentry/components/stackTrace/native/issueThreadStackTrace';
import type {Event} from 'sentry/types/event';
import {EntryType} from 'sentry/types/event';
import type {Group} from 'sentry/types/group';
import type {Organization} from 'sentry/types/organization';
import type {Project} from 'sentry/types/project';
import {defined} from 'sentry/utils/defined';
import {getConfigForIssueType} from 'sentry/utils/issueTypeConfig';
import {isNativePlatform} from 'sentry/utils/platform';
import {useOrganization} from 'sentry/utils/useOrganization';
import {
getHangProfileData,
MetricKitHangProfileSection,
Expand All @@ -27,8 +30,13 @@ interface EventStackTraceProps {
initialCollapse?: boolean;
}

function getEventStackTraceData(event: Event, group: Group) {
const shouldUseNewStackTrace = !isNativePlatform(event.platform);
function getEventStackTraceData(event: Event, group: Group, organization: Organization) {
const isNativeEvent = isNativePlatform(event.platform);
const hasNativeStackTrace = organization.features.includes(
'issue-details-native-stack-trace'
);
const shouldUseNewStackTrace = !isNativeEvent || hasNativeStackTrace;
const shouldUseNewNativeThreadStackTrace = isNativeEvent && hasNativeStackTrace;
const issueTypeConfig = getConfigForIssueType(group, group.project);
const threads = event.entries.findLast(entry => entry.type === EntryType.THREADS);
let exception = event.entries.findLast(entry => entry.type === EntryType.EXCEPTION);
Expand All @@ -51,13 +59,25 @@ function getEventStackTraceData(event: Event, group: Group) {
stacktrace = undefined;
}

return {exception, stacktrace, threads, hangProfileData, shouldUseNewStackTrace};
return {
exception,
stacktrace,
threads,
hangProfileData,
shouldUseNewStackTrace,
shouldUseNewNativeThreadStackTrace,
};
}

export function hasEventStackTrace(event: Event, group: Group): boolean {
export function hasEventStackTrace(
event: Event,
group: Group,
organization: Organization
): boolean {
const {exception, stacktrace, threads, hangProfileData} = getEventStackTraceData(
event,
group
group,
organization
);
return Boolean(hangProfileData || exception || stacktrace || threads);
}
Expand All @@ -68,8 +88,18 @@ export function EventStackTrace({
projectSlug,
initialCollapse,
}: EventStackTraceProps) {
const {exception, stacktrace, threads, hangProfileData, shouldUseNewStackTrace} =
useMemo(() => getEventStackTraceData(event, group), [event, group]);
const organization = useOrganization();
const {
exception,
stacktrace,
threads,
hangProfileData,
shouldUseNewStackTrace,
shouldUseNewNativeThreadStackTrace,
} = useMemo(
() => getEventStackTraceData(event, group, organization),
[event, group, organization]
);
const groupingCurrentLevel = group?.metadata?.current_level;

if (hangProfileData) {
Expand Down Expand Up @@ -128,14 +158,25 @@ export function EventStackTrace({
)}
{defined(threads) && (
<EntryErrorBoundary type={EntryType.THREADS}>
<Threads
initialCollapse={initialCollapse}
event={event}
data={threads.data}
projectSlug={projectSlug}
groupingCurrentLevel={groupingCurrentLevel}
group={group}
/>
{shouldUseNewNativeThreadStackTrace ? (
<IssueThreadStackTrace
initialCollapse={initialCollapse}
event={event}
data={threads.data}
projectSlug={projectSlug}
groupingCurrentLevel={groupingCurrentLevel}
group={group}
/>
) : (
<Threads
initialCollapse={initialCollapse}
event={event}
data={threads.data}
projectSlug={projectSlug}
groupingCurrentLevel={groupingCurrentLevel}
group={group}
/>
)}
</EntryErrorBoundary>
)}
</Fragment>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,18 +136,17 @@ export function NativeContent({
address: frame.instructionAddr,
});

try {
const relativeAddress = (
parseAddress(frame.instructionAddr) -
parseAddress(correspondingImage.image_addr)
).toString(16);

return maxLengthUntilThisPoint > relativeAddress.length
? maxLengthUntilThisPoint
: relativeAddress.length;
} catch {
if (!frame.instructionAddr || !correspondingImage?.image_addr) {
return maxLengthUntilThisPoint;
}

const relativeAddress = (
parseAddress(frame.instructionAddr) - parseAddress(correspondingImage.image_addr)
).toString(16);

return maxLengthUntilThisPoint > relativeAddress.length
? maxLengthUntilThisPoint
: relativeAddress.length;
},
0
);
Expand Down
4 changes: 2 additions & 2 deletions static/app/components/events/interfaces/nativeFrame.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import InteractionStateLayer from 'sentry/components/interactionStateLayer';
import {StrictClick} from 'sentry/components/strictClick';
import {SLOW_TOOLTIP_DELAY} from 'sentry/constants';
import {t, tn} from 'sentry/locale';
import type {ImageWithCombinedStatus} from 'sentry/types/debugImage';
import type {Image} from 'sentry/types/debugImage';
import type {Event, Frame} from 'sentry/types/event';
import type {SentryAppSchemaStacktraceLink} from 'sentry/types/integrations';
import type {PlatformKey} from 'sentry/types/platform';
Expand Down Expand Up @@ -57,7 +57,7 @@ type Props = {
frame: Frame;
frameMeta: Record<any, any>;
hiddenFrameCount: number | undefined;
image: ImageWithCombinedStatus;
image: Image | null;
isFirstInAppFrame: boolean;
/**
* Is the stack trace being previewed in a hovercard?
Expand Down
8 changes: 6 additions & 2 deletions static/app/components/events/interfaces/utils.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,11 @@ interface HiddenFrameIndicesProps {
toggleFrameMap: Record<number, boolean>;
}

export function findImageForAddress({event, addrMode, address}: ImageForAddressProps) {
export function findImageForAddress({
event,
addrMode,
address,
}: ImageForAddressProps): Image | null {
const images = event.entries.find(entry => entry.type === 'debugmeta')?.data?.images;

if (!images || !address) {
Expand All @@ -45,7 +49,7 @@ export function findImageForAddress({event, addrMode, address}: ImageForAddressP
return addrMode === `rel:${idx}`;
});

return image;
return image ?? null;
}

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,34 @@
import {EventFixture} from 'sentry-fixture/event';
import {EventStacktraceFrameFixture} from 'sentry-fixture/eventStacktraceFrame';
import {OrganizationFixture} from 'sentry-fixture/organization';

import {render, screen, userEvent} from 'sentry-test/reactTestingLibrary';

import type {EventError, ExceptionType, ExceptionValue, Frame} from 'sentry/types/event';
import {EntryType} from 'sentry/types/event';

import {StackTracePreview} from './stackTracePreview';
import type {StacktraceType} from 'sentry/types/stacktrace';

import {StackTracePreview, StackTracePreviewContent} from './stackTracePreview';

function makeNativePreview() {
const stacktrace: StacktraceType = {
frames: [
EventStacktraceFrameFixture({
filename: 'ViewController.m',
function: 'ViewController.causeCrash',
inApp: true,
instructionAddr: '0x100001000',
package: '/build/CrashyApp.app/CrashyApp',
platform: 'cocoa',
}),
],
framesOmitted: null,
hasSystemFrames: false,
registers: null,
};

return {event: EventFixture({platform: 'cocoa'}), stacktrace};
}

beforeEach(() => {
MockApiClient.clearMockResponses();
Expand Down Expand Up @@ -103,4 +126,45 @@ describe('StackTracePreview', () => {
// Hide the platform icon for stack trace previews
expect(screen.queryAllByRole('img')).toHaveLength(0);
});

it('renders legacy native stack trace previews without the feature flag', () => {
const {event, stacktrace} = makeNativePreview();

render(<StackTracePreviewContent event={event} stacktrace={stacktrace} />);

expect(screen.getByTestId('stack-trace-frame')).toBeInTheDocument();
expect(
screen.queryByTestId('native-stack-trace-frame-title')
).not.toBeInTheDocument();
});

it('renders new native stack trace previews with the feature flag', () => {
const {event, stacktrace} = makeNativePreview();

render(<StackTracePreviewContent event={event} stacktrace={stacktrace} />, {
organization: OrganizationFixture({features: ['issue-details-native-stack-trace']}),
});

expect(screen.getByTestId('native-stack-trace-frame-title')).toBeInTheDocument();
expect(screen.queryByTestId('stack-trace-frame')).not.toBeInTheDocument();
});

it('shows every system-only native frame in the new preview', () => {
const {event, stacktrace} = makeNativePreview();
stacktrace.frames = ['system_start', 'system_wait', 'system_end'].map(functionName =>
EventStacktraceFrameFixture({
function: functionName,
inApp: false,
platform: 'cocoa',
})
);

render(<StackTracePreviewContent event={event} stacktrace={stacktrace} />, {
organization: OrganizationFixture({features: ['issue-details-native-stack-trace']}),
});

expect(screen.getByText('system_start')).toBeInTheDocument();
expect(screen.getByText('system_wait')).toBeInTheDocument();
expect(screen.getByText('system_end')).toBeInTheDocument();
});
});
45 changes: 31 additions & 14 deletions static/app/components/groupPreviewTooltip/stackTracePreview.tsx
Original file line number Diff line number Diff line change
@@ -1,19 +1,24 @@
import {useEffect, useMemo} from 'react';
import styled from '@emotion/styled';

import {Flex} from '@sentry/scraps/layout';
import {Text} from '@sentry/scraps/text';

import {Content as StackTraceContent} from 'sentry/components/events/interfaces/crashContent/stackTrace/content';
import {NativeContent} from 'sentry/components/events/interfaces/crashContent/stackTrace/nativeContent';
import {findBestThread} from 'sentry/components/events/interfaces/threads/threadSelector/findBestThread';
import {getThreadStacktrace} from 'sentry/components/events/interfaces/threads/threadSelector/getThreadStacktrace';
import {isStacktraceNewestFirst} from 'sentry/components/events/interfaces/utils';
import {LoadingIndicator} from 'sentry/components/loadingIndicator';
import {IssueStackTracePreview} from 'sentry/components/stackTrace/issueStackTrace/issueStackTracePreview';
import {NativeStackTracePreview} from 'sentry/components/stackTrace/native/nativeStackTracePreview';
import {t} from 'sentry/locale';
import type {Event} from 'sentry/types/event';
import {EntryType} from 'sentry/types/event';
import type {StacktraceType} from 'sentry/types/stacktrace';
import {defined} from 'sentry/utils/defined';
import {isNativePlatform} from 'sentry/utils/platform';
import {useOrganization} from 'sentry/utils/useOrganization';

import {GroupPreviewHovercard} from './groupPreviewHovercard';
import {useDelayedLoadingState, usePreviewEvent} from './utils';
Expand Down Expand Up @@ -58,6 +63,7 @@ export function StackTracePreviewContent({
stacktrace: StacktraceType;
groupingCurrentLevel?: number;
}) {
const organization = useOrganization();
const includeSystemFrames = useMemo(() => {
return stacktrace?.frames?.every(frame => !frame.inApp) ?? false;
}, [stacktrace]);
Expand All @@ -78,6 +84,17 @@ export function StackTracePreviewContent({
| Partial<React.ComponentProps<typeof StackTraceContent>>;

if (isNativePlatform(platform)) {
if (organization.features.includes('issue-details-native-stack-trace')) {
return (
<NativeStackTracePreview
event={event}
stacktrace={stacktrace}
platform={platform}
groupingCurrentLevel={groupingCurrentLevel}
/>
);
}

return <NativeContent {...commonProps} groupingCurrentLevel={groupingCurrentLevel} />;
}

Expand Down Expand Up @@ -124,14 +141,14 @@ function StackTracePreviewBody({

if (isPending) {
return (
<NoStackTraceWrapper>
<NoStackTraceMessage>
<LoadingIndicator size={32} />
</NoStackTraceWrapper>
</NoStackTraceMessage>
);
}

if (isError) {
return <NoStackTraceWrapper>{t('Failed to load stack trace.')}</NoStackTraceWrapper>;
return <NoStackTraceMessage>{t('Failed to load stack trace.')}</NoStackTraceMessage>;
}

if (stacktrace && data) {
Expand All @@ -147,9 +164,9 @@ function StackTracePreviewBody({
}

return (
<NoStackTraceWrapper>
<NoStackTraceMessage>
{t('There is no stack trace available for this issue.')}
</NoStackTraceWrapper>
</NoStackTraceMessage>
);
}

Expand Down Expand Up @@ -187,12 +204,12 @@ const StackTracePreviewWrapper = styled('div')`
}
`;

const NoStackTraceWrapper = styled('div')`
color: ${p => p.theme.tokens.content.secondary};
padding: ${p => p.theme.space.lg};
font-size: ${p => p.theme.font.size.md};
display: flex;
align-items: center;
justify-content: center;
min-height: 56px;
`;
function NoStackTraceMessage({children}: {children: React.ReactNode}) {
return (
<Flex align="center" justify="center" padding="lg" minHeight="56px">
<Text as="div" size="md" variant="muted">
{children}
</Text>
</Flex>
);
}
Loading
Loading