Repository navigation
fix(artifact-bundles): Prevent FK violation in indexing race - #125854
Open
sentry[bot] wants to merge 3 commits into
Open
sentry[bot] wants to merge 3 commits into
sentry[bot] wants to merge 3 commits into
Conversation
loewenheim
approved these changes
Sep 29, 2026
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 719bd58. Configure here.
sentry
Bot
force-pushed
the
seer/fix/artifact-bundle-indexing-race
branch
from
September 29, 2026 10:58
719bd58 to
8b12005
Compare
jjbayer
enabled auto-merge (squash)
September 29, 2026 11:05
Contributor
|
The provided test doesn't work. Despite deleting the bundle, no |
Contributor
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
auto-merge was automatically disabled
October 28, 2026 07:00
Pull request was closed
The foreign key from ArtifactBundleIndex to ArtifactBundle is deferred, so Postgres checks it on COMMIT, not on INSERT. Catching IntegrityError around bulk_create never fired. Catch it around the whole transaction instead, and re-raise unless the bundle is actually gone. The regression test uses TransactionTestCase, because TestCase never commits and so never runs the deferred check. Fixes SENTRY-5HG7 Co-Authored-By: Rudra Patel <rudra.patel@sentry.io>
sentry-junior
Bot
force-pushed
the
seer/fix/artifact-bundle-indexing-race
branch
from
November 9, 2026 21:16
128bdcf to
1fc8d25
Compare
Co-Authored-By: Rudra Patel <rudra.patel@sentry.io>
…undle-indexing-race
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR addresses an
IntegrityErrorthat occurs during artifact bundle indexing (sentry.tasks.assemble.assemble_artifacts).Root Cause:
A race condition exists where one worker, processing an artifact bundle for indexing via
index_urls_in_bundle, can have its associatedArtifactBundlerow deleted concurrently by another worker (e.g., through_remove_duplicate_artifact_bundles). If the deletion happens afterindex_urls_in_bundlehas loaded theArtifactBundleobject and prepared itsArtifactBundleIndexentries, but before its transaction commits thebulk_createoperation, the database will raise anIntegrityErrordue to a foreign key constraint violation onsentry_artifactbundleindex.artifact_bundle_id.Fix:
index_urls_in_bundleis updated to wrap theArtifactBundleIndex.objects.bulk_createcall in atry/except IntegrityErrorblock. If anIntegrityErroroccurs, it indicates that theArtifactBundlehas been deleted. In this scenario, the function now catches the error, increments a new metric (artifact_bundle_indexing.bundle_deleted_during_indexing) for observability, and returns silently. This is the correct behavior as there is no longer anArtifactBundleto index.Test Update:
The existing test
test_index_urls_in_bundle_deleted_bundle_is_ignoredintests/sentry/debug_files/test_artifact_bundles.pywas updated. Previously, deleting theArtifactBundlealso deleted its associatedFile, causing the test to fail prematurely withFile.DoesNotExistbefore theIntegrityErrorcould be triggered. The test now correctly simulates the race condition by opening theArtifactBundleArchivebefore deleting theArtifactBundlerow, ensuring that thebulk_createcall (and thus theIntegrityErrorhandler) is properly exercised.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-5HG7
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.