Repository navigation
ref(integrations): Convert InstalledIntegration to a functional component - #127867
Merged
Merged
Conversation
cvxluo
approved these changes
Nov 3, 2026
Contributor
There was a problem hiding this comment.
Looks good to me. This is a straight class-to-function port: the props interface is the same, getRemovalBodyAndText moves to module scope unchanged, the confirm and disable handlers close over the same integration prop they used to take as an argument, and the access, tooltip, and disabled logic inside Access is carried over as-is. The only callers (integrationDetailedView.tsx and the spec) render it as JSX with no refs or instance access, so nothing relied on it being a class. Jest passed.
The red getsentry dispatch check is just the label gate for bot-authored PRs (Trigger: getsentry tests is missing), so it doesn't reflect a failure in this change.
ryan953
approved these changes
Nov 20, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert
InstalledIntegration(static/app/views/settings/organizationIntegrations/installedIntegration.tsx) from a legacy React class component to a functional component.[no-class-components]on line 42.Componentimport fromreact.getRemovalBodyAndTextto module scope.integrationStatus,removeConfirmProps,disableConfirmProps) and event handlers into local variables/callbacks.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes CODING-CONVENTIONS-9GD
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this run