Skip to content

ref(integrations): Convert InstalledIntegration to a functional component - #127867

Merged
ryan953 merged 1 commit into
masterfrom
seer/ref/convert-installed-integration-to-fc
Nov 20, 2026
Merged

ryan953 merged 1 commit into
masterfrom
seer/ref/convert-installed-integration-to-fc

Conversation

@sentry

@sentry sentry Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Convert InstalledIntegration (static/app/views/settings/organizationIntegrations/installedIntegration.tsx) from a legacy React class component to a functional component.

  • Resolves coding conventions violation [no-class-components] on line 42.
  • Drops the Component import from react.
  • Moves static helper getRemovalBodyAndText to module scope.
  • Converts getter properties (integrationStatus, removeConfirmProps, disableConfirmProps) and event handlers into local variables/callbacks.
  • Preserves the existing component interface, behavior, and test coverage.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Fixes CODING-CONVENTIONS-9GD

@sentry <feedback>: Autofix iterates on these changes
@sentry stop iterating: Autofix stops iterating on this run

@sentry
sentry Bot requested a review from a team as a code owner October 16, 2026 20:21
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 16, 2026
@ryan953
ryan953 requested a review from a team October 16, 2026 20:22

@sentry-junior sentry-junior Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This is a straight class-to-function port: the props interface is the same, getRemovalBodyAndText moves to module scope unchanged, the confirm and disable handlers close over the same integration prop they used to take as an argument, and the access, tooltip, and disabled logic inside Access is carried over as-is. The only callers (integrationDetailedView.tsx and the spec) render it as JSX with no refs or instance access, so nothing relied on it being a class. Jest passed.

The red getsentry dispatch check is just the label gate for bot-authored PRs (Trigger: getsentry tests is missing), so it doesn't reflect a failure in this change.

@ryan953 ryan953 added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Nov 20, 2026
@ryan953
ryan953 enabled auto-merge (squash) November 20, 2026 16:45
@ryan953
ryan953 merged commit eaa6003 into master Nov 20, 2026
99 of 100 checks passed
@ryan953
ryan953 deleted the seer/ref/convert-installed-integration-to-fc branch November 20, 2026 16:48

This branch was successfully deployed

1 active deployment
Preview — bbe97e24 Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants