Repository navigation
fix(uptime): Count Railway and Amplify apps as separate domains - #128638
Open
rgrey-xicoia wants to merge 1 commit into
Open
rgrey-xicoia wants to merge 1 commit into
rgrey-xicoia wants to merge 1 commit into
Conversation
Add up.railway.app and amplifyapp.com as extra tldextract suffixes. Both are on the live public suffix list but missing from the snapshot bundled with tldextract 5.1.2, so every app on them shared one per-domain limit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
@getsentry/crons could someone take a look at this when there's a chance please? It's a small change to the per-domain uptime limit, following on from #108070. Thanks. |
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
up.railway.appandamplifyapp.comas extra suffixes for the uptime per-domain limit. Each app on these hosts now counts as its own domain, asonrender.comandvercel.appapps already do.Both suffixes are on the live public suffix list but missing from the snapshot bundled with tldextract 5.1.2. So every app on them shares one global count. #108070 noted
railway.appandamplifyapp.comwere saturated and raised the limit. This fixes the cause for those two.What changes
Longer term
A fresher tldextract snapshot would make this list unnecessary. I've asked for one in john-kurkowski/tldextract#385. Once Sentry upgrades, these two entries can be removed.
How to test
pytest tests/sentry/uptime/autodetect/test_url_extraction.py. The new tests fail against the current code.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.