Skip to content

fix(uptime): Count Railway and Amplify apps as separate domains - #128638

Open
rgrey-xicoia wants to merge 1 commit into
getsentry:masterfrom
rgrey-xicoia:fix/uptime-railway-amplify-suffixes
Open

rgrey-xicoia wants to merge 1 commit into
getsentry:masterfrom
rgrey-xicoia:fix/uptime-railway-amplify-suffixes

Conversation

@rgrey-xicoia

Copy link
Copy Markdown

Adds up.railway.app and amplifyapp.com as extra suffixes for the uptime per-domain limit. Each app on these hosts now counts as its own domain, as onrender.com and vercel.app apps already do.

Both suffixes are on the live public suffix list but missing from the snapshot bundled with tldextract 5.1.2. So every app on them shares one global count. #108070 noted railway.app and amplifyapp.com were saturated and raised the limit. This fixes the cause for those two.

What changes

  • New monitors on these hosts start their own count.
  • Existing monitors move to their own count the next time they are edited.
  • Other domains and autodetection are unchanged.

Longer term

A fresher tldextract snapshot would make this list unnecessary. I've asked for one in john-kurkowski/tldextract#385. Once Sentry upgrades, these two entries can be removed.

How to test

pytest tests/sentry/uptime/autodetect/test_url_extraction.py. The new tests fail against the current code.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Add up.railway.app and amplifyapp.com as extra tldextract suffixes. Both
are on the live public suffix list but missing from the snapshot bundled
with tldextract 5.1.2, so every app on them shared one per-domain limit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rgrey-xicoia
rgrey-xicoia requested a review from a team as a code owner October 23, 2026 10:32
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 23, 2026
@rgrey-xicoia

Copy link
Copy Markdown
Author

@getsentry/crons could someone take a look at this when there's a chance please? It's a small change to the per-domain uptime limit, following on from #108070. Thanks.

@getsantry

getsantry Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry Bot added the Stale label Nov 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant