Skip to content

ref(flags): Remove organizations:autofix-browser-notifications registration - #129456

Merged
ryan953 merged 4 commits into
masterfrom
claude-rm-autofix-browser-notifications-registration
Nov 20, 2026
Merged

ryan953 merged 4 commits into
masterfrom
claude-rm-autofix-browser-notifications-registration

Conversation

@cursor

@cursor cursor Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Remove the temporary.py registration for organizations:autofix-browser-notifications. The flag was rolled out to GA in the automator in getsentry/sentry-options-automator#9026 on 8/3, and hasn't been touched since.

Last of three, merge in order:

  1. ref(flags): Graduate organizations:autofix-browser-notifications in the UI #129455 — frontend reads
  2. getsentry/sentry-options-automator#10417 — flagpole value
  3. this PR

The flag has no backend readers, so this does not depend on #129455 for green CI; the ordering is so the flagpole block is never orphaned and api_expose keeps emitting the flag while the UI still reads it.

The Disable for sandbox org segment the flagpole block carried is preserved in code as !isDemoModeActive() by #129455.

Open in Web View Automation 

…ration

GA in the automator since #9026 (2026-08-03). Reads removed in #129455,
flagpole value in getsentry/sentry-options-automator#10417.

Co-authored-by: charlie.luo <charlie.luo@sentry.io>
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 1, 2026
@cursor
cursor Bot marked this pull request as ready for review November 1, 2026 20:39
@cursor
cursor Bot requested a review from ryan953 November 1, 2026 20:39

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@getsentry/machine-learning-ai — last of three for organizations:autofix-browser-notifications, opened by the stale-flag-cleanup automation. @ryan953 is requested as reviewer since he created and rolled out the flag.

Merge this one last: #129455 (frontend reads) → getsentry/sentry-options-automator#10417 (flagpole value) → this PR. The flag has no backend readers, so green CI here does not depend on #129455 — the ordering exists so the flagpole block is never orphaned and so api_expose keeps emitting the flag while the UI still reads it.

The flagpole block carried a Disable for sandbox org segment above its GA segment; #129455 preserves that as !isDemoModeActive() and explains why. Worth reading that PR's discussion before merging this one.

CI is green apart from getsentry dispatch, which gates on the author having write permission and always fails for cursor[bot] — a collaborator needs to add the Trigger: getsentry tests label.

View PR

Open in Web View Automation 

Sent by Cursor Automation: Feature flag cleanup

@ryan953 ryan953 added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Nov 18, 2026
…rowser-notifications-registration

# Conflicts:
#	src/sentry/features/temporary.py
@github-actions github-actions Bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Nov 18, 2026
@ryan953 ryan953 added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Nov 18, 2026
@ryan953
ryan953 enabled auto-merge (squash) November 19, 2026 21:00
@ryan953 ryan953 added Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests and removed Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests labels Nov 19, 2026
@github-actions github-actions Bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Nov 19, 2026
@ryan953 ryan953 added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Nov 19, 2026
@github-actions github-actions Bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Nov 20, 2026
@ryan953 ryan953 added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Nov 20, 2026
@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Backend Test Failures

Failures on 4c2a1ec in this run:

tests/snuba/api/endpoints/test_organization_events_span_indexed.py::OrganizationEventsSpansEndpointTest::test_device_class_filter_out_unknown — log
[gw0] linux -- Python 3.13.18 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/snuba/api/endpoints/test_organization_events_span_indexed.py:396: in test_device_class_filter_out_unknown
    assert len(data) == 3
E   AssertionError: assert 4 == 3
E    +  where 4 = len([{'device.class': 'low', 'count()': 1.0}, {'device.class': 'medium', 'count()': 1.0}, {'device.class': 'high', 'count()': 1.0}, {'device.class': None, 'count()': 1.0}])
tests/snuba/api/endpoints/test_organization_events_span_indexed.py::OrganizationEventsSpansEndpointTest::test_device_class_filter_for_empty — log
[gw1] linux -- Python 3.13.18 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/snuba/api/endpoints/test_organization_events_span_indexed.py:324: in test_device_class_filter_for_empty
    assert data[0]["count()"] == 2
E   assert 1.0 == 2
tests/snuba/api/endpoints/test_organization_events_span_indexed.py::OrganizationEventsSpansEndpointTest::test_device_class_filter_for_unknown — log
[gw0] linux -- Python 3.13.18 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/snuba/api/endpoints/test_organization_events_span_indexed.py:361: in test_device_class_filter_for_unknown
    assert data[0]["count()"] == 2
E   assert 1.0 == 2

@ryan953
ryan953 merged commit 165d219 into master Nov 20, 2026
153 of 178 checks passed
@ryan953
ryan953 deleted the claude-rm-autofix-browser-notifications-registration branch November 20, 2026 19:37

This branch was successfully deployed

1 active deployment
Preview — 6d766979 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants