Skip to content

ref(workflow_engine): Pass detectors explicitly to actions - #131089

Closed
shashjar wants to merge 1 commit into
masterfrom
shashjar/ref/iswf-3705-explicit-action-detector
Closed

shashjar wants to merge 1 commit into
masterfrom
shashjar/ref/iswf-3705-explicit-action-detector

Conversation

@shashjar

@shashjar shashjar commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Closed without merging. Action execution will keep its existing signature and use get_preferred_detector() for centralized detector selection; the investigation-event branch will land with the concrete event/detector integration.

The remaining stack is #131090 (action-side group-less support) followed by #131093 (Inbox frequency semantics). Neither requires this refactor.

Refs https://linear.app/getsentry/issue/ISWF-3705/support-group-less-action-invocation-and-inbox-frequency-semantics.

https://app.notion.com/p/sentry/Investigation-Events-Workflow-Engine-40c8b10e4b5d80d18c4ed6c802d55d64

@linear-code

linear-code Bot commented Nov 13, 2026

Copy link
Copy Markdown

ISWF-3705

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 13, 2026
@shashjar
shashjar added this pull request to stack #131096 November 13, 2026 18:30
@shashjar
shashjar force-pushed the shashjar/ref/iswf-3705-explicit-action-detector branch from 66383a6 to 86593bd Compare November 13, 2026 18:39
@shashjar
shashjar force-pushed the shashjar/ref/iswf-3705-explicit-action-detector branch from 86593bd to c8bf5e8 Compare November 19, 2026 23:59
@github-actions

Copy link
Copy Markdown
Contributor

decision-model-linter

api

src/sentry/workflow_engine/models/action.py

  • warn makesExistingInputStricter = TRUE (0.84): Rejecting input an endpoint accepted before, or changing a field's default, breaks existing callers, and the API spec often doesn't show it. Make the change backward compatible (keep the field optional, accept the old values, or keep the old default), or treat it as a breaking change and coordinate it.

decision-model-linter: 14 calls on 3 files, 29,917 input tokens, $0.0013, model typesafe/jev-1.13-20260917

@shashjar
shashjar removed this pull request from stack #131096 November 20, 2026 00:15
@shashjar shashjar closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant