Repository navigation
feat(dashboards): Add a unified visualize list for trace metrics widgets - #131366
Conversation
📊 Type Coverage Diff✅ no issues found |
cf5432e to
85394e4
Compare
|
No findings on the latest commit. |
39538f4 to
7f17d76
Compare
7f17d76 to
301eec7
Compare
301eec7 to
3923a6e
Compare
27802c5 to
2e3c38b
Compare
2e3c38b to
d9a6fa5
Compare
d9a6fa5 to
9dae195
Compare
Behind the dashboards-trace-metrics-unified-visualize flag: aggregates and equations share one list with row letters, per-row filters, and hide/show for rows only an equation uses.
Editing one duplicate no longer rewrites the equation, and repeated uses read back as distinct letters.
…nches Keeps the legacy row where master has it, so the diff is only the new pieces.
…s rule by dataset
Letters belong to rows, equations stay in letter form, and the old per-render derivation is gone. Claude-Session: https://claude.ai/code/session_016ys9JvwtMgVv9brzjTEzNJ
…arios in the unified list Claude-Session: https://claude.ai/code/session_016ys9JvwtMgVv9brzjTEzNJ
9dae195 to
256f4d6
Compare
|
Tried to split out parts of this change into other PRs as much as possible. Still, some of the files in this pr have quite a lot of changes, and it might not be obvious what some of the code blocks are doing. Feel free to ping me if needed! 🙏 |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit eb79df8. Configure here.
| commit(setRowVisible(rows, row.id, false)); | ||
| } | ||
| }, | ||
| show: row => commit(setRowVisible(rows, row.id, true)), |
There was a problem hiding this comment.
Show bypasses the metrics cap
Medium Severity
hasMaxMetrics only counts visible fields, and show never checks that cap. A widget at MAX_METRICS_ALLOWED can still reveal a hidden series an equation uses, so the query goes over the 10-series limit Add Series and Add Equation already block.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit eb79df8. Configure here.
| const row = visibleRows[index]; | ||
| if (row) { | ||
| commit(setRowVisible(rows, row.id, false)); | ||
| } |
There was a problem hiding this comment.
Hide desyncs selected aggregate index
Medium Severity
Hiding a series removes it through SET_FIELDS / SET_Y_AXIS / SET_CATEGORICAL_AGGREGATE and never adjusts selectedAggregate. DELETE_AGGREGATE shifts or clears that index for Big Number and Categorical Bar radios, so hide can point the radio at the wrong remaining row or past the end of the list.
Reviewed by Cursor Bugbot for commit eb79df8. Configure here.


Updates the widget viewer for trace metrics to allow querying for fields, aggregates, and equations within the same widget.
This change gets rid of the
SeriesvsEquationsmode for trace metric widgets, which only allowed users to exclusively render a single equation or several aggregates.The trace metric row entries in the widget builder are managed by a
TraceMetricRowfromrowModel.tsin the groundwork pr:#131366
We still continue to support building equations by referencing A, B, C letter form labels, and we also continue supporting the pattern of "hidden" aggregates by saving them inline with equations and parsing them out when opening in the widget builder.
Behind the
dashboards-trace-metrics-unified-visualizeflag.