Repository navigation
Conversation
No receiver acts on a team that still exists, so create and edit outboxes only made the request wait on a drain. Deletes keep theirs: the tombstone cleans up control silo rows linked to the team.
Mirror Project's outbox_for_update helper, rename the receiver to say it only acts on deletes, and pin the delete outbox's shard and object id in a test.
The hybrid cloud foreign key check requires every link target to expose outbox_for_update, as Project does.
…outbox-deletes-only
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves CTRL-107
Stops team creates and edits from writing an outbox, so those requests no longer wait on a drain.
Nothing in the control silo copies team fields, so those messages reached an empty handler. Deletes still write one, left for the background workers as before (unlike
Project.delete, which flushes), because its tombstone is what cleans up the team's notification settings.Channel provisioning used to get its new partner account into control only because a later team save drained the organization's queue in the same request. Since #131729, the
flush=Truethatcreate_partner_accountalready passes takes effect, so it no longer depends on that; getsentry/getsentry#23355 adds a test for it.