Skip to content

feat(hybridcloud): write team outboxes on delete only - #131410

Open
ldelvoye wants to merge 4 commits into
masterfrom
ldelvoye/feat/team-outbox-deletes-only
Open

ldelvoye wants to merge 4 commits into
masterfrom
ldelvoye/feat/team-outbox-deletes-only

Conversation

@ldelvoye

@ldelvoye ldelvoye commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

resolves CTRL-107

Stops team creates and edits from writing an outbox, so those requests no longer wait on a drain.

Nothing in the control silo copies team fields, so those messages reached an empty handler. Deletes still write one, left for the background workers as before (unlike Project.delete, which flushes), because its tombstone is what cleans up the team's notification settings.

Channel provisioning used to get its new partner account into control only because a later team save drained the organization's queue in the same request. Since #131729, the flush=True that create_partner_account already passes takes effect, so it no longer depends on that; getsentry/getsentry#23355 adds a test for it.

No receiver acts on a team that still exists, so create and edit
outboxes only made the request wait on a drain. Deletes keep theirs:
the tombstone cleans up control silo rows linked to the team.
Mirror Project's outbox_for_update helper, rename the receiver to say it
only acts on deletes, and pin the delete outbox's shard and object id in
a test.
@linear-code

linear-code Bot commented Nov 17, 2026

Copy link
Copy Markdown

CTRL-107

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 17, 2026
The hybrid cloud foreign key check requires every link target to expose
outbox_for_update, as Project does.
@ldelvoye
ldelvoye marked this pull request as ready for review November 20, 2026 21:13
@ldelvoye
ldelvoye requested a review from a team as a code owner November 20, 2026 21:13
@ldelvoye
ldelvoye requested a review from a team November 20, 2026 21:23

This branch was successfully deployed

1 active deployment
Preview — 3c917ed1 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant