Repository navigation
feat(tracemetrics): Use configured standard retention for max pickable days - #131468
Draft
sentry-junior[bot] wants to merge 3 commits into
Draft
sentry-junior[bot] wants to merge 3 commits into
sentry-junior[bot] wants to merge 3 commits into
Conversation
… behind a flag With organizations:dashboards-tracemetrics-90-day-range, trace metrics date pickers allow the org's trace metrics retention, capped at 90 days, instead of a fixed 30 days. Co-Authored-By: Dominik Buszowiecki <44422760+DominikB2014@users.noreply.github.com>
…etention-picker Co-Authored-By: Dominik Buszowiecki <44422760+DominikB2014@users.noreply.github.com> # Conflicts: # static/gsApp/overrides/useMaxPickableDays.tsx
…e days Drop the dashboards-tracemetrics-90-day-range flag and the downsampled retention. Every plan includes 13 months of downsampled trace metrics retention, which may be removed, so only a configured standard retention longer than 30 days raises the date picker limit. Co-Authored-By: Dominik Buszowiecki <44422760+DominikB2014@users.noreply.github.com>
This was referenced Nov 20, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In SaaS, the trace metrics (Application Metrics) date range is hardcoded to 30 days, so orgs that have a longer trace metrics retention configured can't pick a range that reaches it.
The
TRACE_METRICScase in the gsAppuseMaxPickableDaysoverride now uses the subscription'seffectiveRetentions.traceMetric.standard, with 30 days as the floor. It ignoresdownsampledon purpose: every plan includes 13 months of downsampled trace metrics retention, and that may be removed, so we don't want everyone's picker to open up to it.standardis 30 on every plan unless an org-wide or per-category retention override is set, so only orgs with an explicit longer retention see a change.No feature flag. The override itself is the gate, so #131466 and #131467 are closed. Changing the default for all orgs waits until the downsampled retention decision is made.
Open decisions:
via @DominikB2014.
--
View Session [Sentry]