Repository navigation
fix(seer): End the thinking timer when an Autofix step stops for credits - #131716
Merged
Merged
Conversation
A step that stopped for credits mid-tool-call has no final answer once its error block is hidden, so its thinking block looked like it was still running: expanded, with the timer counting up. The card now ends the timer at the error block's timestamp, and the block collapses. Fixes CW-3108
srest2021
marked this pull request as ready for review
November 19, 2026 00:18
srest2021
requested review from
a team and
billyvg
and removed request for
a team
November 19, 2026 00:19
billyvg
reviewed
Nov 19, 2026
Only the last response in a stopped step ran until Seer's error block. An earlier one, for example one that asked the user a question, now ends at the user's next message instead. Renames ResponseGroup's stoppedAt prop to endedAt, since it is no longer always the stop.
Contributor
📊 Type Coverage Diff✅ no issues found |
billyvg
reviewed
Nov 19, 2026
A response followed by a user message ended at Seer's error block when it was the step's last response, so a step that ran out of credits right after the user's message counted their time as Seer's. Every response now ends at the user message after it, or at the error block when nothing follows. Splits the tests into one case each, including a running step.
billyvg
approved these changes
Nov 20, 2026
The card hid every Seer error block, not just the one it stopped at. In a single run, where a reply follows a failure without cutting it, the response before an earlier error then ran until the user's reply. Only the trailing error block is hidden now, so an earlier one stays as its response's answer. Each response ends at the next block in the full list, which drops stoppedAt. Adds tests for earlier error and credit-stop blocks, a step that doesn't end in an error block, the plan card and a stopped PR iteration, and moves the timing tests to 5-second steps.
Showing earlier error blocks read as Seer repeating itself, since the card doesn't draw the user's replies between them. The card hides every Seer error block again, as before. Timers stay right, because each response ends at the next block in the full list, hidden or not. Groups the transcript tests, drops the two that only applied to showing earlier error blocks and renames the rest.
Only single runs take replies inside a step, so the root cause tests with a user message now use a single-run run state, tag their blocks like Seer does and say so in their names. Rewords the StepResponses comment to cover a segment with nothing after it.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CW-3108
Problem: When an Autofix step stops for credits mid-tool-call, its thinking block stays expanded with the "Thinking…" animation, and the timer keeps counting up indefinitely, so the step looks like it's still running. A step that stops for credits ends with Seer's error block, which the card hides because it shows its own out-of-credits line. Without that block, the step has no final answer, so the timer never ends. CW-3108 reported this on a PR iteration, and it happens on the root cause, plan and code changes steps too.
This PR: ends each response in the step at the block after it, and passes that time to the thinking block as
endedAt.endedAt. The Seer Agent chat doesn't, so it's unchanged.Before:

After:
