Skip to content

fix(seer): End the thinking timer when an Autofix step stops for credits - #131716

Merged
srest2021 merged 8 commits into
masterfrom
fix/seer-credit-stop-thinking-block
Nov 20, 2026
Merged

srest2021 merged 8 commits into
masterfrom
fix/seer-credit-stop-thinking-block

Conversation

@srest2021

@srest2021 srest2021 commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Fixes CW-3108

Problem: When an Autofix step stops for credits mid-tool-call, its thinking block stays expanded with the "Thinking…" animation, and the timer keeps counting up indefinitely, so the step looks like it's still running. A step that stops for credits ends with Seer's error block, which the card hides because it shows its own out-of-credits line. Without that block, the step has no final answer, so the timer never ends. CW-3108 reported this on a PR iteration, and it happens on the root cause, plan and code changes steps too.

This PR: ends each response in the step at the block after it, and passes that time to the thinking block as endedAt.

  • For the last response, that's Seer's hidden error block, so the block collapses and the timer ends when the step stopped.
  • A response followed by a user message, which only happens when you reply in a single run's chat, ends at that message. This also applies while the step is still running.
  • Every error block stays hidden. In a single run that failed and was then continued, the response before the earlier error still ends at that error.
  • Only the Autofix cards pass endedAt. The Seer Agent chat doesn't, so it's unchanged.

Before:
image

After:
image

A step that stopped for credits mid-tool-call has no final answer once its error block is hidden,
so its thinking block looked like it was still running: expanded, with the timer counting up.
The card now ends the timer at the error block's timestamp, and the block collapses.

Fixes CW-3108
@linear-code

linear-code Bot commented Nov 18, 2026

Copy link
Copy Markdown

CW-3108

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 18, 2026
@srest2021
srest2021 marked this pull request as ready for review November 19, 2026 00:18
@srest2021
srest2021 requested a review from a team as a code owner November 19, 2026 00:18
@srest2021
srest2021 requested review from a team and billyvg and removed request for a team November 19, 2026 00:19
Only the last response in a stopped step ran until Seer's error block. An earlier one, for
example one that asked the user a question, now ends at the user's next message instead.
Renames ResponseGroup's stoppedAt prop to endedAt, since it is no longer always the stop.
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

✅ no issues found

A response followed by a user message ended at Seer's error block when it was the step's last
response, so a step that ran out of credits right after the user's message counted their time
as Seer's. Every response now ends at the user message after it, or at the error block when
nothing follows. Splits the tests into one case each, including a running step.
The card hid every Seer error block, not just the one it stopped at. In a single run, where a
reply follows a failure without cutting it, the response before an earlier error then ran until
the user's reply. Only the trailing error block is hidden now, so an earlier one stays as its
response's answer. Each response ends at the next block in the full list, which drops stoppedAt.

Adds tests for earlier error and credit-stop blocks, a step that doesn't end in an error block,
the plan card and a stopped PR iteration, and moves the timing tests to 5-second steps.
Showing earlier error blocks read as Seer repeating itself, since the card doesn't draw the
user's replies between them. The card hides every Seer error block again, as before. Timers stay
right, because each response ends at the next block in the full list, hidden or not.

Groups the transcript tests, drops the two that only applied to showing earlier error blocks
and renames the rest.
Only single runs take replies inside a step, so the root cause tests with a user message now use a
single-run run state, tag their blocks like Seer does and say so in their names. Rewords the
StepResponses comment to cover a segment with nothing after it.
@srest2021
srest2021 merged commit 6c794ef into master Nov 20, 2026
89 checks passed
@srest2021
srest2021 deleted the fix/seer-credit-stop-thinking-block branch November 20, 2026 21:57

This branch was successfully deployed

1 active deployment
Preview — 77269364 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants