Repository navigation
Conversation
DominikB2014
left a comment
Contributor
There was a problem hiding this comment.
Looking good! Mostly nits but some genuine good practices. I would also see if there's anyone on dev infra to take a quick look
…f shell Replace publish-api-baseline.sh with a TypeScript module run by actions/github-script. It commits through the Git Data API, so the job needs no git identity, jq, or gh, and GitHub signs the bot's commit. Co-Authored-By: Joshua Li <14209781+joshuarli@users.noreply.github.com>
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
…-9066-keep-exceptionsjson-up-to-date-in
joshuarli
approved these changes
Nov 21, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear issue
our current
exceptions.jsonis a snapshot from when it was first generated (so Nov 19th), so it goes stale as people fix violations, add new ones, or move endpoints between teams. This PR adds a daily workflow that refreshes it from main and opens a bot PR when something actually changed so that the report card stays accurate without anyone running the commands by handI made
refresh-api-baseline.ymlrun daily at 09:00 UTC, and can also be run by hand from the Actions tab. It has two jobs which follow the same pattern asprune-oxlint-suppressions.yml:scanrunsmake api-owner-mapandmake api-baseline ARGS="--update"with read-only access, and uploads the newexceptions.jsonas an artifact.--updatekeeps any reviewedstatus/reasonvalues so that a refresh never wipes thempublishis the only job with the bot token. It runspublish-api-baseline.sh, which checks the artifact looks like an exceptions file, and compares only theentrieswith master's copy.generatedandcommitchange on every run, so comparing the whole file would open a PR every day. If the entries changed it force-pushesbot/update-api-baselineand opens a PR if one isn't already openThe workflow also runs on PRs that change it or its script, but only
scanruns there. I made it like this so that changes to it get tested before they merge (that's what ran on this PR)