Repository navigation
feat(dashboards): Hatch the background behind low confidence data - #131988
sentry-junior[bot] wants to merge 5 commits into
Conversation
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-3lt1hqvxz.sentry.dev |
gggritso
left a comment
There was a problem hiding this comment.
This looks okay overall, but I'm wondering about code re-use, and whether it makes sense to use Plottable where we can encode information about the confidence and creating another Plottable for this kind of hatching, so it's more re-usable and contained.
b508aaf to
dd29b58
Compare
|
@cursor review |
gggritso
left a comment
There was a problem hiding this comment.
This is looking quite decent, a few questions and suggestions
Time series charts with the data-browsing-time-series-confidence feature now hatch the full plot height behind every stretch of time where a visible series has a low confidence bucket. Ranges from all series are merged, so the treatment is per chart rather than per series. Fixes BROWSE-908 Co-Authored-By: George Gritsouk <george.gritsouk@sentry.io>
…plottable ContinuousTimeSeries now reports its own low confidence ranges, and a generic FullHeightAreas plottable draws hatched areas across the full plot height. TimeSeriesWidgetVisualization creates that plottable at runtime and plots it after the plottables it was given. Refs BROWSE-908
FullHeightAreas hardcoded a number data type, so on charts without a number axis (durations, rates) the y axis lookup reported a Could not assign Plottable to an axis error on every render. Take the type of the first plottable, which always gets the left axis. Refs BROWSE-908 Co-Authored-By: George Gritsouk <george.gritsouk@sentry.io>
FullHeightAreas takes its ranges as a constructor argument, like ContinuousTimeSeries takes its time series, and expects them already merged. The bounds it clips to come in at render time through toSeries. The visualization memoizes the low confidence areas. Refs BROWSE-908
d61e3da to
f5bb096
Compare
gggritso
left a comment
There was a problem hiding this comment.
Very good, just a few more changes
The visualization spec now only checks that the low confidence areas follow the feature flag; HatchAreas and ContinuousTimeSeries specs cover the details. Refs BROWSE-908
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit c5e883e. Configure here.
An improvement to our work on showing confidence information. This adds a little cross-hatch background to areas of low confidence on time series charts.
e.g.,
It turned out that mark areas don't support this kind of decal, so we had to use a custom series, oh well!
Closes BROWSE-908
via George Gritsouk.
--
View Session [Sentry]