Skip to content

feat(dashboards): Hatch the background behind low confidence data - #131988

Open
sentry-junior[bot] wants to merge 5 commits into
masterfrom
feat/low-confidence-background-hatch
Open

sentry-junior[bot] wants to merge 5 commits into
masterfrom
feat/low-confidence-background-hatch

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

An improvement to our work on showing confidence information. This adds a little cross-hatch background to areas of low confidence on time series charts.

e.g.,

Light Dark

It turned out that mark areas don't support this kind of decal, so we had to use a custom series, oh well!

Closes BROWSE-908

via George Gritsouk.

--

View Session [Sentry]

@linear-code

linear-code Bot commented Nov 20, 2026

Copy link
Copy Markdown

BROWSE-908

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Story previews

Preview the stories changed in this PR on the Vercel deployment:

Preview deployment: https://sentry-3lt1hqvxz.sentry.dev

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 20, 2026

@gggritso gggritso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay overall, but I'm wondering about code re-use, and whether it makes sense to use Plottable where we can encode information about the confidence and creating another Plottable for this kind of hatching, so it's more re-usable and contained.

@sentry-junior
sentry-junior Bot force-pushed the feat/low-confidence-background-hatch branch from b508aaf to dd29b58 Compare November 20, 2026 20:19

Copy link
Copy Markdown
Member

@cursor review

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@gggritso gggritso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking quite decent, a few questions and suggestions

sentry-junior Bot and others added 4 commits November 20, 2026 20:43
Time series charts with the data-browsing-time-series-confidence feature
now hatch the full plot height behind every stretch of time where a
visible series has a low confidence bucket. Ranges from all series are
merged, so the treatment is per chart rather than per series.

Fixes BROWSE-908

Co-Authored-By: George Gritsouk <george.gritsouk@sentry.io>
…plottable

ContinuousTimeSeries now reports its own low confidence ranges, and a
generic FullHeightAreas plottable draws hatched areas across the full
plot height. TimeSeriesWidgetVisualization creates that plottable at
runtime and plots it after the plottables it was given.

Refs BROWSE-908
FullHeightAreas hardcoded a number data type, so on charts without a
number axis (durations, rates) the y axis lookup reported a Could not
assign Plottable to an axis error on every render. Take the type of the
first plottable, which always gets the left axis.

Refs BROWSE-908

Co-Authored-By: George Gritsouk <george.gritsouk@sentry.io>
FullHeightAreas takes its ranges as a constructor argument, like
ContinuousTimeSeries takes its time series, and expects them already
merged. The bounds it clips to come in at render time through toSeries.
The visualization memoizes the low confidence areas.

Refs BROWSE-908

@gggritso gggritso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, just a few more changes

The visualization spec now only checks that the low confidence areas
follow the feature flag; HatchAreas and ContinuousTimeSeries specs cover
the details.

Refs BROWSE-908
@gggritso

Copy link
Copy Markdown
Member

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit c5e883e. Configure here.

@gggritso
gggritso marked this pull request as ready for review November 20, 2026 21:50
@gggritso
gggritso requested review from a team as code owners November 20, 2026 21:50

This branch was successfully deployed

1 active deployment
Preview — c5e883e4 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant