Repository navigation
Conversation
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-41sravfl4.sentry.dev |
leeandher
force-pushed
the
feat/impact-citation-ui
branch
from
November 20, 2026 17:03
86c20f2 to
5cf3b44
Compare
leeandher
force-pushed
the
feat/impact-citation-ui
branch
from
November 20, 2026 17:05
5cf3b44 to
73ffb4f
Compare
leeandher
added a commit
that referenced
this pull request
Nov 20, 2026
> AI COMMENTARY > knip's production check flagged the shared examples, which only tests and > stories use, and parseCitation, which the Impact citation UI (#132028) is > the first production caller of. The examples move to __fixtures__, and > the schema is a temporary production entry until that PR lands.
leeandher
force-pushed
the
feat/impact-citation-ui
branch
from
November 20, 2026 17:25
73ffb4f to
339802c
Compare
This was referenced Nov 20, 2026
> AI COMMENTARY > Impact assessments with typed citations now list each claim with a chip > per citation (the kind's icon plus the cited title, with the excerpt as > a tooltip). Pressing a chip expands its detail: kind, where in the datum > (frame, tag, stat, replay offset, query result), timestamp, the exact > excerpt, and the datum itself rendered by the matching Seer embed (event, > trace waterfall, log, replay, profile, issue or query). Code, commits, > PRs, feedback and external links fall back to a link. > > citationToEmbed maps citations onto existing embeds, so chat, > investigations and Impact can share one rendering. A test checks every > example citation produces data its embed's schema accepts. Assessments > without typed citations keep the previous tag list.
leeandher
force-pushed
the
feat/impact-citation-ui
branch
from
November 20, 2026 17:43
339802c to
8674c37
Compare
Contributor
Sentry Snapshot Testing
|
> AI COMMENTARY > The Citations story could only expand the kinds that render without a > fetch. useStoryCitations now builds a citation of every kind from the > signed-in organization, using the Seer embed stories' discovery queries: > - issue (and its user count) > - the latest event, with its crash frame, a tag and the user > - a trace, preferring the issue's project > - logs scoped to the issue's project > - a profile, a replay, and an errors query > The other kinds use the static examples. > > "All kinds" expands one section per kind, noting kinds the organization > has no data for. "Chips" expands any chip. "In an Impact assessment" > renders the real ImpactClaims layout with these citations.
Contributor
📊 Type Coverage Diff
🔍 2 new type safety issues introducedType assertions (
This is informational only and does not block the PR. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Commentary
Stack: typed citations for Seer — 4 of 4 (Sentry frontend).
An Impact assessment with typed citations now lists each claim with a chip per citation. A chip shows the kind's icon and the cited title, with the excerpt as a tooltip.
Pressing a chip expands its detail:
Code, commits, PRs, feedback and external citations fall back to a link.
citationToEmbedmaps citations onto the existing embeds, so Impact, chat and investigations can share one rendering. A test checks that every example citation maps to data its embed's own schema accepts. Assessments without typed citations keep the old tag list.Verified end to end on a dev box: seeded checkout-crash events, a v2 run, and Seer's real tool output delivered through
deliver_feature_result. Claims rendered with frame, tag, user-context, replay and issue-stat citations, and the expanded frame showed the cited source line with the event card.Previewing: the Citations story (Scraps → Seer → Citations → Citation) has an "All kinds" section with one expanded detail per kind, built from the signed-in organization's data, plus an "In an Impact assessment" section with the real claims layout.
Related PRs
Sentry stack (stack):
Seer stack (stack):
Order: Sentry 1–2 and Seer 1–2 can land in any order. Seer 3 (Impact v2) must deploy before Sentry 3 turns on
organizations:seer-impact-typed-citations. Sentry 4 renders whatever Sentry 3 stores.