Repository navigation
fix(preprod): Return null for empty mobile build size buckets - #132034
Open
sentry-junior[bot] wants to merge 3 commits into
Open
sentry-junior[bot] wants to merge 3 commits into
sentry-junior[bot] wants to merge 3 commits into
Conversation
DominikB2014
marked this pull request as ready for review
November 20, 2026 17:43
adrianviquez
approved these changes
Nov 20, 2026
events-timeseries zerofilled the preprodSize dataset, so a bucket with no build reported a size of 0. Callers that read the API directly saw the app shrink to nothing between builds and could not tell that apart from real data. Empty buckets now return null. When a query has no results at all, the empty buckets are still built so the series covers the requested range, with null values when zerofill is off. Refs DAIN-1504 Co-Authored-By: Dominik Buszowiecki <44422760+DominikB2014@users.noreply.github.com>
sentry-junior
Bot
force-pushed
the
fix/preprod-size-timeseries-null-empty-buckets
branch
from
November 20, 2026 18:03
5ef1f89 to
3289f4e
Compare
Contributor
|
@trevor-e i'm curious if you have any opinions on this change |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/events-timeseries/zerofilled thepreprodSizedataset, so a bucket with no build reported a size of 0. Anything reading the API directly, such as an agent or an MCP tool, sees the app drop to 0 bytes between builds and has no way to tell that apart from real data. Empty buckets now returnnull, which correctly means there was no build in that bucket.organization_events_timeseries.py: thePreprodSizeresolver config setszerofill_timeseries=False. Buckets wheredata_presentis false then serialize asnull, for both plain and top-events (grouped) queries.rpc_dataset_common.py: if a query returns no results at all,run_timeseries_querystill builds the empty buckets and sets them tonullwhen zerofill is off, so the series still covers the requested range. Before, that branch was skipped when zerofill was off, which would have returnedvalues: []. The only other caller with zerofill off is the heatmap y-bounds query, and its result stays(0, 0)either way.The dashboard doesn't change. The mobile builds line transform (#131681) already treats
nulland0as empty buckets, and empty bars render the same. After this lands, the frontend=== 0check can be removed.This is step one. Step two is applying
fill(locf)by default for size aggregates, withfilledflags, so API consumers get the carried-forward size the dashboard shows.Decisions
/events-stats/still zerofillspreprodSize, andtest_zerofill_no_datathere asserts on it. Conclusion : This is fine, Nothing in the frontend readspreprodSizethrough events-stats and that's the old apicount()is affected too: empty buckets forcount()on this dataset also becomenullinstead of0. Conclusion: This is fine, but not as ideal, have 0 counts probably makes more sense, but that's much smaller of a problem then showing 0 instead of null for other aggregates like maxRefs DAIN-1504
via @DominikB2014.
--
View Session [Sentry]