Repository navigation
feat(dashboards): Add a row model for the unified trace metrics visualize list - #132043
Open
edwardgou-sentry wants to merge 6 commits into
Open
edwardgou-sentry wants to merge 6 commits into
edwardgou-sentry wants to merge 6 commits into
Conversation
…lize list Rows get stable ids and letters, equations stay in letter form while editing, and the saved shape is derived from the rows. Claude-Session: https://claude.ai/code/session_016ys9JvwtMgVv9brzjTEzNJ
Contributor
📊 Type Coverage Diff
🔍 2 new type safety issues introducedNon-null assertions (
This is informational only and does not block the PR. |
| entry: [ | ||
| ...productionEntryPoints.map(entry => `${entry}!`), | ||
| ...frontendWorkspace.entry, | ||
| 'views/dashboards/widgetBuilder/components/visualize/traceMetrics/rowModel.ts!', |
Contributor
Author
There was a problem hiding this comment.
need this for now since file is unused and will cause knip failure. Will be deleted on the first pr that uses the new file.
…ide edits in the row model Claude-Session: https://claude.ai/code/session_016ys9JvwtMgVv9brzjTEzNJ
…ding the row model Equations that still spell their saved text keep their letters and hidden rows, and visible fields prefer rows that were already visible. Claude-Session: https://claude.ai/code/session_016ys9JvwtMgVv9brzjTEzNJ
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 82a172c. Configure here.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds
TraceMetricRowtypes to model field, aggregate, and equation rows in the trace metric widget builder for the unified visualize view.Also includes several helper functions to manage editing rows. The new types and helper functions are not used yet and will be leveraged in an upcoming pr.