Skip to content

feat(dashboards): Add a row model for the unified trace metrics visualize list - #132043

Open
edwardgou-sentry wants to merge 6 commits into
masterfrom
edwardgou-sentry/feat/trace-metric-row-model
Open

edwardgou-sentry wants to merge 6 commits into
masterfrom
edwardgou-sentry/feat/trace-metric-row-model

Conversation

@edwardgou-sentry

@edwardgou-sentry edwardgou-sentry commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Adds TraceMetricRow types to model field, aggregate, and equation rows in the trace metric widget builder for the unified visualize view.
Also includes several helper functions to manage editing rows. The new types and helper functions are not used yet and will be leveraged in an upcoming pr.

…lize list

Rows get stable ids and letters, equations stay in letter form while editing, and the saved shape is derived from the rows.

Claude-Session: https://claude.ai/code/session_016ys9JvwtMgVv9brzjTEzNJ
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 20, 2026
@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

Metric Before After Delta
Coverage 96.12% 96.12% ±0%
Typed 145,056 145,192 🟢 +136
Untyped 5,863 5,865 🔴 +2
🔍 2 new type safety issues introduced

Non-null assertions (!) (2 new)

File Line Detail
static/app/views/dashboards/widgetBuilder/components/visualize/traceMetrics/rowModel.ts 183 referenceMap[token.text]!
static/app/views/dashboards/widgetBuilder/components/visualize/traceMetrics/rowModel.ts 219 letters[n % letters.length]!

This is informational only and does not block the PR.

Comment thread knip.config.ts
entry: [
...productionEntryPoints.map(entry => `${entry}!`),
...frontendWorkspace.entry,
'views/dashboards/widgetBuilder/components/visualize/traceMetrics/rowModel.ts!',

@edwardgou-sentry edwardgou-sentry Nov 20, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need this for now since file is unused and will cause knip failure. Will be deleted on the first pr that uses the new file.

@edwardgou-sentry
edwardgou-sentry marked this pull request as ready for review November 20, 2026 20:35
@edwardgou-sentry
edwardgou-sentry requested review from a team as code owners November 20, 2026 20:35
@edwardgou-sentry
edwardgou-sentry requested a review from a team November 20, 2026 20:35

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

…ding the row model

Equations that still spell their saved text keep their letters and hidden rows, and visible fields prefer rows that were already visible.

Claude-Session: https://claude.ai/code/session_016ys9JvwtMgVv9brzjTEzNJ

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 82a172c. Configure here.

This branch was successfully deployed

1 active deployment
Preview — 36d908bd Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant