Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {parseAsString, useQueryState} from 'nuqs';
import {Button} from '@sentry/scraps/button';
import {CodeBlock} from '@sentry/scraps/codeBlock';
import {ExternalLink} from '@sentry/scraps/link';
import {Heading} from '@sentry/scraps/text';

import type {AnnotationItem} from 'sentry/components/charts/annotations/types';
import {ConfigStore} from 'sentry/stores/configStore';
Expand Down Expand Up @@ -58,6 +59,25 @@ const sampleDurationTimeSeriesP75: TimeSeries = {
}),
};

const sampleDurationTimeSeriesP90: TimeSeries = {
...sampleDurationTimeSeries,
yAxis: 'p90(span.duration)',
values: sampleDurationTimeSeries.values.map(datum => {
return {...datum, value: datum.value ? datum.value * 0.7 + 30 * Math.random() : null};
}),
};

const sampleDurationTimeSeriesP95: TimeSeries = {
...sampleDurationTimeSeries,
yAxis: 'p95(span.duration)',
values: sampleDurationTimeSeries.values.map(datum => {
return {
...datum,
value: datum.value ? datum.value * 0.85 + 30 * Math.random() : null,
};
}),
};

const shiftedSpanSamples = shiftTabularDataToNow(spanSamplesWithDurations);

const releases = [
Expand Down Expand Up @@ -836,26 +856,32 @@ export default Storybook.story('TimeSeriesWidgetVisualization', story => {
});

story('Low Confidence Data', () => {
const createLowConfidenceTimeSeriesClone = function (
timeSeries: TimeSeries
): TimeSeries {
return {
...timeSeries,
values: timeSeries.values.map((value, index) => {
if ((index > 10 && index < 16) || (index > 30 && index < 33)) {
return {...value, confidence: 'low'};
}
return value;
}),
};
};
const lowConfidenceDuration = withLowConfidenceIntervals(sampleDurationTimeSeries, [
[20, 25],
]);

const twoIntervals: LowConfidenceInterval[] = [
[10, 15],
[30, 33],
];
const twoIntervalsDurations = [
sampleDurationTimeSeries,
sampleDurationTimeSeriesP95,
sampleDurationTimeSeriesP90,
sampleDurationTimeSeriesP75,
sampleDurationTimeSeriesP50,
].map(timeSeries => withLowConfidenceIntervals(timeSeries, twoIntervals));

const lowConfidenceDurationTimeSeries = createLowConfidenceTimeSeriesClone(
sampleDurationTimeSeries
);
const lowConfidenceDurationP50TimeSeries = createLowConfidenceTimeSeriesClone(
sampleDurationTimeSeriesP50
);
const fiveIntervals: LowConfidenceInterval[] = [
[3, 5],
[10, 12],
[18, 22],
[28, 30],
[38, 41],
];

// 47 of 49 points, just over 95% of the chart
const mostlyLowConfidence: LowConfidenceInterval[] = [[2, 48]];

return (
<Fragment>
Expand All @@ -866,32 +892,79 @@ export default Storybook.story('TimeSeriesWidgetVisualization', story => {
</p>

<WithTimeSeriesConfidenceFeature>
<Storybook.SideBySide>
<MediumWidget>
<Heading as="h3" size="md">
Single series, one low-confidence interval
</Heading>
<Storybook.Grid columns={3}>
<GridWidget>
<TimeSeriesWidgetVisualization
plottables={[new Line(lowConfidenceDuration)]}
/>
</GridWidget>
<GridWidget>
<TimeSeriesWidgetVisualization
plottables={[new Area(lowConfidenceDuration)]}
/>
</GridWidget>
<GridWidget>
<TimeSeriesWidgetVisualization
plottables={[new Bars(lowConfidenceDuration)]}
/>
</GridWidget>
</Storybook.Grid>

<Heading as="h3" size="md">
Five series, two low-confidence intervals
</Heading>
<Storybook.Grid columns={3}>
<GridWidget>
<TimeSeriesWidgetVisualization
plottables={[
new Line(lowConfidenceDurationTimeSeries),
new Line(lowConfidenceDurationP50TimeSeries),
]}
plottables={twoIntervalsDurations.map(timeSeries => new Line(timeSeries))}
/>
</MediumWidget>
<MediumWidget>
</GridWidget>
<GridWidget>
<TimeSeriesWidgetVisualization
plottables={[
new Area(lowConfidenceDurationTimeSeries),
new Area(lowConfidenceDurationP50TimeSeries),
]}
plottables={twoIntervalsDurations.map(timeSeries => new Area(timeSeries))}
/>
</MediumWidget>
<MediumWidget>
</GridWidget>
<GridWidget>
<TimeSeriesWidgetVisualization
plottables={[
new Bars(lowConfidenceDurationTimeSeries, {stack: 'all'}),
new Bars(lowConfidenceDurationP50TimeSeries, {stack: 'all'}),
]}
plottables={twoIntervalsDurations.map(
timeSeries => new Bars(timeSeries, {stack: 'all'})
)}
/>
</MediumWidget>
</Storybook.SideBySide>
</GridWidget>
</Storybook.Grid>

<Heading as="h3" size="md">
Multiple lines, five low-confidence intervals
</Heading>
<LargeWidget>
<TimeSeriesWidgetVisualization
plottables={[
sampleDurationTimeSeries,
sampleDurationTimeSeriesP75,
sampleDurationTimeSeriesP50,
].map(
timeSeries =>
new Line(withLowConfidenceIntervals(timeSeries, fiveIntervals))
)}
/>
</LargeWidget>

<Heading as="h3" size="md">
Multiple bars, more than 95% low confidence
</Heading>
<LargeWidget>
<TimeSeriesWidgetVisualization
plottables={[sampleDurationTimeSeries, sampleDurationTimeSeriesP50].map(
timeSeries =>
new Bars(withLowConfidenceIntervals(timeSeries, mostlyLowConfidence), {
stack: 'all',
})
)}
/>
</LargeWidget>
</WithTimeSeriesConfidenceFeature>
</Fragment>
);
Expand Down Expand Up @@ -1416,6 +1489,12 @@ const MediumWidget = styled('div')`
height: 250px;
`;

const GridWidget = styled('div')`
position: relative;
min-width: 0;
height: 250px;
`;

const SmallWidget = styled('div')`
position: relative;
width: 360px;
Expand Down Expand Up @@ -1533,6 +1612,25 @@ const X_AXIS_TICK_TEST_CASES: Array<{endMs: number; label: string; startMs: numb
},
];

/**
* Inclusive start and end indexes of a run of low-confidence data points.
*/
type LowConfidenceInterval = [start: number, end: number];

function withLowConfidenceIntervals(
timeSeries: TimeSeries,
intervals: LowConfidenceInterval[]
): TimeSeries {
return {
...timeSeries,
values: timeSeries.values.map((value, index) =>
intervals.some(([start, end]) => index >= start && index <= end)
? {...value, confidence: 'low'}
: value
),
};
}

function WithTimeSeriesConfidenceFeature({children}: {children: ReactNode}) {
const organization = useOrganization();

Expand Down
Loading