Repository navigation
feat(service-accounts): Add token management to service account settings - #132066
Draft
sentry-junior[bot] wants to merge 1 commit into
Draft
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
List a service account's access tokens on its details page, create tokens in a modal that shows the value once, and revoke them after a confirm. Accounts owned by a Seer automation stay read-only. Refs ENG-9091 Co-Authored-By: Shaun Kaasten <900809+skaasten@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Service accounts can be created and edited in settings, but there was no way to give one a token, so they couldn't be used from CI or scripts yet. This PR adds token management to the service account details page, using the existing token endpoints. It's the last PR in the stack after #131795, #131876 and #132041. It's frontend only and stays behind
organizations:service-accounts. The design follows the prototype in #131689.sntrym_plus the last 4 characters), its scopes, created date, last used and expiry. Tokens that expire within 7 days or have already expired get a tag. The section has an empty state and pagination.useCannotManageReasoncheck as Edit and Delete. They're disabled for accounts owned by a Seer automation, which are read-only in settings, and for users withoutservice_account:write. Tokens are still listed for those accounts.getFieldErrorsinserviceAccountForm.tsxnow takes a list of fields, so the token form can reuse it.Refs ENG-9091
via @skaasten.
--
View Session [Sentry]