Repository navigation
ref(releases): Remove experimental release threshold endpoints - #132067
Open
sentry-junior[bot] wants to merge 1 commit into
Open
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Remove the experimental release threshold create, list, update, and delete endpoints, which have no callers and no UI, and the unused /release-thresholds/ page route. Mark the public status endpoint deprecated. It is exported by @sentry/api, so removing it waits for that package's next major release. Refs ISWF-3793 Co-Authored-By: Athena Moghaddam <132939361+sentaur-athena@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release thresholds have no UI. Their last real caller was the getsentry canary deploy check, which getsentry/getsentry#22979 removed. This PR removes the parts that can go now and deprecates the one endpoint that has to stay until the next @sentry/api major release.
Removed
ReleaseThresholdIndexEndpoint,ReleaseThresholdEndpoint, andReleaseThresholdDetailsEndpoint(allEXPERIMENTAL, so none of them are in the public spec or @sentry/api), along with their URLs and tests/release-thresholds/React page route. The frontend has no route for it.as_str_choiceshelpers that only those endpoints usedknownSentryApiUrlsentriesDeprecated
ReleaseThresholdStatusIndexEndpoint(listOrganizationReleaseThresholdStatuses) isPUBLIC_EXPERIMENTALand is exported by @sentry/api 2.16.0. Removing an export waits for a major release, so this PR addsdeprecated=Trueinstead. The client then tags it@deprecated. The endpoint, theReleaseThresholdmodel, and the health-check helpers stay for now.#131982 removes the rest, including the model migration, once the major is ready.
Refs ISWF-3793
via @sentaur-athena.
--
View Session [Sentry]