Repository navigation
Conversation
Contributor
decision-model-linterapi
decision-model-linter: 15 calls on 3 files, 35,253 input tokens, $0.0015, model typesafe/jev-1.13-20260917 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metric detector limit now counts only enabled, active
metric_issuedetectors, so disabling a detector frees up room under the plan's limit. Previously disabled detectors counted too, so an org at its limit had to delete detectors to make room.Because disabled detectors no longer count, every path that enables one now checks the limit, otherwise a user could create detectors disabled and enable them past the limit:
PUTon detector details) is rejected at the limit with the same message create uses.PUTon the org detector index) counts the disabled metric detectors in the selection and rejects the whole request if enabling them would go over. Already-enabled detectors aren't counted.Create is unchanged: it's still rejected at the limit, including when the request sends
enabled: false, because create doesn't honorenabledand always makes an enabled detector.The count and the enable check live in
src/sentry/incidents/metric_detector_quota.pyso every path uses the same rule.The plan limit still comes from
quotas.backend.get_metric_detector_limit, and theorganizations:workflow-engine-metric-detector-limitflag gates it as before.