Skip to content

Remove cssselect from mypy missing-stubs allowlist - #132107

Draft
cursor[bot] wants to merge 1 commit into
masterfrom
cursor/bc-40ee8e5c-9af7-40e4-b145-174f6da98910-1ede
Draft

cursor[bot] wants to merge 1 commit into
masterfrom
cursor/bc-40ee8e5c-9af7-40e4-b145-174f6da98910-1ede

Conversation

@cursor

@cursor cursor Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove cssselect.* from the mypy missing-stubs override list in pyproject.toml
  • add local stubs for cssselect and cssselect.parser under fixtures/stubs-for-mypy/
  • update SelectorType in src/sentry/replays/lib/selector/parse.py to include CombinedSelector, fixing the newly-exposed arg-type/unreachable mypy errors

Testing

  • .venv/bin/python -m tools.mypy_helpers.check_stronglist pyproject.toml
  • SENTRY_CONF=/tmp/sentry-mypy-config PYTHONPATH=src .venv/bin/mypy --config-file pyproject.toml src/sentry/replays/lib/selector
  • SENTRY_CONF=/tmp/sentry-mypy-config PYTHONPATH=src .venv/bin/prek run -q

cc @armenzg for review.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Open in Web View Automation 

Co-authored-by: Armen <armenzg@users.noreply.github.com>
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant