Skip to content

fix(onboarding): Keep the framework prompt usable on mobile - #132109

Open
Harbeytee wants to merge 5 commits into
getsentry:masterfrom
Harbeytee:fix/framework-modal-mobile-scroll
Open

Harbeytee wants to merge 5 commits into
getsentry:masterfrom
Harbeytee:fix/framework-modal-mobile-scroll

Conversation

@Harbeytee

Copy link
Copy Markdown

Selecting Node.js on a phone while creating a project froze the screen, so I could not enter a project name or continue. The framework prompt opened in the global modal, which locks page scrolling. On mobile Chrome the dialog sat outside the visible screen, and that lock captured every tap.

The same prompt now opens in a bottom sheet. The page stays usable, and choosing a framework, skipping, or closing the sheet still continues project creation.

Fixes #132108

Selecting Node.js on a phone while creating a project froze the screen,
so I could not enter a project name or continue. Show the framework
prompt in a bottom sheet so the page stays usable.

Fixes getsentry#132108
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 21, 2026
@Harbeytee
Harbeytee marked this pull request as ready for review November 21, 2026 20:47
@Harbeytee
Harbeytee requested a review from a team as a code owner November 21, 2026 20:47

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Selecting a framework submitted the create-project form, so the project
name never updated. Keep that submit on the prompt, and expose the prompt
as a dialog.

Fixes getsentry#132108
The sheet scrolled as one block, so expanding frameworks pushed Configure SDK out of reach, and the page behind the prompt stayed interactive. The list now scrolls inside the sheet. A backdrop blocks the page, focus stays in the prompt, and Escape or the backdrop closes it.

Fixes getsentry#132108

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2c4411f. Configure here.

The sheet wrappers were not the styled modal components, so the prompt props failed typechecking. Use the modal body and footer directly.

Fixes getsentry#132108
Hiding the page marked the backdrop inert, so a tap on it never closed the prompt. Hide outside the prompt, which includes the backdrop.

Fixes getsentry#132108

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Selecting Node.js on mobile freezes project creation

1 participant