Repository navigation
Conversation
Selecting Node.js on a phone while creating a project froze the screen, so I could not enter a project name or continue. Show the framework prompt in a bottom sheet so the page stays usable. Fixes getsentry#132108
Harbeytee
marked this pull request as ready for review
November 21, 2026 20:47
Selecting a framework submitted the create-project form, so the project name never updated. Keep that submit on the prompt, and expose the prompt as a dialog. Fixes getsentry#132108
The sheet scrolled as one block, so expanding frameworks pushed Configure SDK out of reach, and the page behind the prompt stayed interactive. The list now scrolls inside the sheet. A backdrop blocks the page, focus stays in the prompt, and Escape or the backdrop closes it. Fixes getsentry#132108
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2c4411f. Configure here.
The sheet wrappers were not the styled modal components, so the prompt props failed typechecking. Use the modal body and footer directly. Fixes getsentry#132108
Hiding the page marked the backdrop inert, so a tap on it never closed the prompt. Hide outside the prompt, which includes the backdrop. Fixes getsentry#132108
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Selecting Node.js on a phone while creating a project froze the screen, so I could not enter a project name or continue. The framework prompt opened in the global modal, which locks page scrolling. On mobile Chrome the dialog sat outside the visible screen, and that lock captured every tap.
The same prompt now opens in a bottom sheet. The page stays usable, and choosing a framework, skipping, or closing the sheet still continues project creation.
Fixes #132108