Repository navigation
fix: require the full 28-byte block-count table in list-blocks responses - #939
Merged
Merged
Conversation
gijzelaerr
force-pushed
the
fix-list-blocks-response-table
branch
from
October 7, 2026 09:58
00ebdfa to
1738da4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #931.
parse_list_blocks_responseonly required the payload length to be a multiple of four, so an empty or truncated table was reported as zero blocks, and a duplicate block type silently overwrote an earlier count. Native Snap7 requires the data length to be exactly 28 bytes (seven four-byte entries). The parser now requires exactly seven entries with distinct, known type codes and raisesS7ProtocolErrorotherwise. The bundled server already sends the full table.