Disable reopen wontfix#234
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the “file” GitHub Action so that previously-closed scanner-filed issues are not reopened on subsequent runs when the issue is labeled wontfix, and documents the behavior for users.
Changes:
- Add
isWontfixIssue()helper and integrate it into the repeated-filing (reopen) path sowontfixissues stay closed. - Add Vitest coverage for the new label-check behavior, plus regression adjustments to existing tests.
- Document how to keep an issue closed using the
wontfixlabel.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents the wontfix label behavior for preventing reopen. |
| .github/actions/file/src/index.ts | Skips reopening repeated filings when the issue is labeled wontfix. |
| .github/actions/file/src/isWontfixIssue.ts | New helper to fetch issue labels and detect wontfix. |
| .github/actions/file/tests/wontfixReopen.test.ts | New end-to-end-ish test ensuring wontfix issues are not reopened. |
| .github/actions/file/tests/isWontfixIssue.test.ts | Unit tests for label detection and request routing. |
| .github/actions/file/tests/dryRun.test.ts | Updates regression guard to account for the new label-check GET request when not in dry-run. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 6/6 changed files
- Comments generated: 1
|
🤔 I wonder if instead of making one API request per issue, it would work to attempt to grab all Another possibility: the repository in question may not even have |
Good idea! I've implemented this in the new commit. |
Co-authored-by: Joyce Zhu <joycezhu@github.com>
Closes https://github.com/github/accessibility/issues/10756.
Closing a scanner-filed issue without merging a fix used to cause it to reopen on the next run. Adding the
wontfixlabel now keeps it closed