Repository navigation
Skip redundant per-member check in filtered_members contract - #90
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The review evidence identifies no unresolved concerns in the contract-validation change or the synchronized version updates.
No open issues 🎉
What changed in this PR
This pull request removes redundant per-member contract validation from Base#filtered_members while preserving its Set return guarantee, and bumps the version to 1.2.11.
Changes:
- Validates
filtered_membersas aSetwithout rechecking each member. - Updates the application and locked gem versions to 1.2.11.
| File | Description |
|---|---|
lib/version.rb |
Updates the application version to 1.2.11. |
lib/entitlements/data/groups/calculated/base.rb |
Removes redundant per-member validation from the filtered-members contract. |
Gemfile.lock |
Synchronizes the locked gem version with 1.2.11. |
Review effort: Lite (auto)
nobe4
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #89, plus a version bump to 1.2.11.
Base#filtered_membersis memoised, but its return contract checked every member of the set on each call. The set is derived frommembers, whose contract already checks each element, so this contract now checks only that aSetis returned.Tests:
bundle exec rspec spec/unitpasses (568 examples, 0 failures, 100% coverage).