Skip to content

Skip redundant per-member check in filtered_members contract - #90

Merged
Ayomi-gh merged 1 commit into
mainfrom
ayomi-gh/filtered-members-contract
Nov 6, 2026
Merged

Ayomi-gh merged 1 commit into
mainfrom
ayomi-gh/filtered-members-contract

Conversation

@Ayomi-gh

@Ayomi-gh Ayomi-gh commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #89, plus a version bump to 1.2.11.

Base#filtered_members is memoised, but its return contract checked every member of the set on each call. The set is derived from members, whose contract already checks each element, so this contract now checks only that a Set is returned.

Tests: bundle exec rspec spec/unit passes (568 examples, 0 failures, 100% coverage).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI adaptive review requested due to automatic review settings November 6, 2026 15:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The review evidence identifies no unresolved concerns in the contract-validation change or the synchronized version updates.

No open issues 🎉

What changed in this PR

This pull request removes redundant per-member contract validation from Base#filtered_members while preserving its Set return guarantee, and bumps the version to 1.2.11.

Changes:

  • Validates filtered_members as a Set without rechecking each member.
  • Updates the application and locked gem versions to 1.2.11.
File Description
lib/​version.rb Updates the application version to 1.2.11.
lib/​entitlements/​data/​groups/​calculated/​base.rb Removes redundant per-member validation from the filtered-members contract.
Gemfile.lock Synchronizes the locked gem version with 1.2.11.

Review effort: Lite (auto)

@Ayomi-gh
Ayomi-gh merged commit 35cb2c5 into main Nov 6, 2026
20 of 21 checks passed
@Ayomi-gh
Ayomi-gh deleted the ayomi-gh/filtered-members-contract branch November 6, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants