Skip to content

[docs] Update Astro dependencies - 2026-06-24#41258

Merged
pelikhan merged 3 commits into
mainfrom
docs/update-astro-2026-06-24-bd52264ed296cf43
Jun 24, 2026
Merged

[docs] Update Astro dependencies - 2026-06-24#41258
pelikhan merged 3 commits into
mainfrom
docs/update-astro-2026-06-24-bd52264ed296cf43

Conversation

@github-actions

@github-actions github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Generated by PR Description Updater for #41258 · 54.4 AIC · ⌖ 9.08 AIC · ⊞ 4.6K ·

Update npm packages in docs/ to latest versions.

- astro: ^6.4.6 → ^7.0.2 (major)
- @astrojs/starlight: ^0.40.0 → ^0.41.0 (minor)
- astro-mermaid: ^2.0.2 → ^2.0.4 (patch)
- sharp: ^0.35.1 → ^0.35.2 (patch)
- @playwright/test: ^1.61.0 → ^1.61.1 (patch)
- starlight-github-alerts: ^0.2.0 → ^0.3.0 (minor)

Migration (Astro 7): Move markdown.remarkPlugins / rehypePlugins
into unified({...}) from @astrojs/markdown-remark, per the
new processor API. Adds @astrojs/markdown-remark as a direct
dependency.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation labels Jun 24, 2026
@pelikhan pelikhan marked this pull request as ready for review June 24, 2026 17:04
Copilot AI review requested due to automatic review settings June 24, 2026 17:04
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Test Quality Sentinel completed test quality analysis.

No test files were added or modified in this PR. Test Quality Sentinel skipped. PR #41258 only updates Astro documentation dependencies (docs/astro.config.mjs, docs/package.json, docs/package-lock.json).

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

PR Code Quality Reviewer completed the code quality review.

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #41258 does not have the 'implementation' label and has 0 new lines of code in business logic directories (threshold 100). Only 3 files changed, all outside business logic paths.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the documentation site (docs/) to Astro 7 and refreshes related npm dependencies, including migrating the Markdown configuration to Astro 7’s processor: unified(...) API via @astrojs/markdown-remark.

Changes:

  • Bump astro to ^7.0.2 and update related Starlight/build/test dependencies.
  • Add @astrojs/markdown-remark as a direct dependency for the Astro 7 Markdown processor migration.
  • Update docs/astro.config.mjs to use markdown.processor: unified({ ... }) instead of deprecated top-level remarkPlugins/rehypePlugins.
Show a summary per file
File Description
docs/package.json Updates docs dependencies for Astro 7 and adds @astrojs/markdown-remark.
docs/package-lock.json Refreshes the resolved dependency graph for the updated docs toolchain.
docs/astro.config.mjs Migrates Markdown plugin configuration to Astro 7’s processor: unified(...) API.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/3 changed files
  • Comments generated: 3

Comment thread docs/package.json Outdated
Comment thread docs/package.json Outdated
Comment on lines 45 to 46
"overrides": {
"@astrojs/markdown-remark": "^7.2.0"
Comment thread docs/package-lock.json Outdated
@github-actions github-actions Bot mentioned this pull request Jun 24, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking observations on this Astro 6→7 migration. The migration logic is correct and the build passes; two maintainability issues are worth a follow-up.

Findings summary

docs/package.json — duplicate version pin

@astrojs/markdown-remark@^7.2.0 now appears in both dependencies (added here) and overrides (pre-existing). This creates a two-place edit requirement on every future version bump. Either document why both exist or remove the now-redundant override.

docs/astro.config.mjsunified import name ambiguity

The imported name unified collides with the well-known unified npm package. A one-line comment or alias (createMarkdownProcessor) makes the origin clear for developers unfamiliar with Astro 7's new processor API.

🔎 Code quality review by PR Code Quality Reviewer · 58.2 AIC · ⌖ 7.75 AIC · ⊞ 5.2K

Comment thread docs/package.json Outdated
"starlight-github-alerts": "^0.3.0"
},
"overrides": {
"@astrojs/markdown-remark": "^7.2.0"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant entry: @astrojs/markdown-remark is now pinned in both dependencies and overrides, creating a two-place maintenance burden on every future version bump.

💡 Details

The overrides block was added in a previous commit to force the transitive dependency up to v7.2.x. This PR now also adds it as a direct dependency. These two entries coexist with identical version ranges:

"dependencies": {
  "`@astrojs/markdown-remark`": "^7.2.0"  // direct dep (added here)
},
"overrides": {
  "`@astrojs/markdown-remark`": "^7.2.0"  // transitive pin (pre-existing)
}

If the override is still needed to force the version for other packages in the dependency tree, it should stay — but a comment explaining that intent would prevent future developers from deleting it as a perceived duplicate. If the override is no longer needed now that there is a direct dependency, it should be removed. As-is, a version bump requires two coordinated edits.

Comment thread docs/astro.config.mjs
import starlightBlog from 'starlight-blog';
import mermaid from 'astro-mermaid';
import { fileURLToPath } from 'node:url';
import { unified } from '@astrojs/markdown-remark';

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unified is also the name of the popular unified npm package, so this import will confuse developers familiar with the remark/rehype ecosystem but not yet with Astro 7's new processor API.

💡 Suggested fix

Add a clarifying comment or alias to make the origin unmistakable:

// unified() is `@astrojs/markdown-remark`'s processor factory, not the unified npm package
import { unified } from '`@astrojs/markdown-remark`';

or use an alias:

import { unified as createMarkdownProcessor } from '`@astrojs/markdown-remark`';
// ...
processor: createMarkdownProcessor({ remarkPlugins: [...], rehypePlugins: [...] }),

This removes the guesswork about which unified this is and avoids a naming collision if the actual unified package is ever imported for a custom plugin.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skills-Based Review 🧠

Applied /grill-with-docs — approving this clean, well-executed Astro 7 migration.

📋 Key Themes & Highlights

Positive Highlights

  • ✅ Correct migration from deprecated remarkPlugins/rehypePlugins to processor: unified({...}) following the Astro 7 API
  • ✅ PR description thoroughly documents all changes, including the known starlight-blog upstream deprecation warning (outside our control)
  • ✅ Build verified: 192 pages built, all internal links valid
  • ✅ Having @astrojs/markdown-remark as both a direct dependency and in overrides is intentional — the direct dep satisfies the import in astro.config.mjs, while the override forces transitive consumers (e.g. starlight-blog) to also resolve v7.2.0

Minor Observation (Non-Blocking)

  • starlight-github-alerts bumped from ^0.2.0^0.3.0 (minor version). The PR body does not mention what changed in this package. Worth a quick changelog check before merging.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · 41.5 AIC · ⌖ 7.88 AIC · ⊞ 6.5K

@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot run pr-finisher skill

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@copilot run pr-finisher skill

Done in d803bf6. I ran the PR-finisher flow, pinned @astrojs/markdown-remark to 7.2.0 in docs/package.json (dependency + override) and docs/package-lock.json root spec, and validated with make fmt, make lint, make test-unit, make test, make recompile, and parallel_validation (all passed). CI on this new HEAD still needs a maintainer-triggered re-run before merge.

Copilot AI requested a review from pelikhan June 24, 2026 18:21
@github-actions

Copy link
Copy Markdown
Contributor Author

Re-run CI on the current head, then address any lingering non-blocking review comments if needed.

Generated by 👨‍🍳 PR Sous Chef · 66.5 AIC · ⌖ 1.12 AIC · ⊞ 17.6K ·

@pelikhan pelikhan merged commit 43cc4cb into main Jun 24, 2026
8 checks passed
@pelikhan pelikhan deleted the docs/update-astro-2026-06-24-bd52264ed296cf43 branch June 24, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants