WebGPU: Convert material reference to uint rather than struct#774
Open
gkjohnson wants to merge 1 commit into
Open
WebGPU: Convert material reference to uint rather than struct#774gkjohnson wants to merge 1 commit into
gkjohnson wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@TheBlek - I think this is what we'd discussed in #770: converting the global scratch material reference to a uint rather than copying the full material to improve register use. Maybe this is where better GPU-side timing instrumentation would be useful but I'm not seeing any meaningful difference in performance or anything when testing the rover model. Are there improvements on your end?