Repository navigation
Conversation
2 tasks done
trasher
approved these changes
Oct 9, 2025
trasher
left a comment
trasher
left a comment
Contributor
There was a problem hiding this comment.
GLPI core no longer requires session from CLI; but won't that be an issue if a plugin does?
cedric-anne
added a commit
to pluginsGLPI/databaseinventory
that referenced
this pull request
Oct 9, 2025
2 tasks done
Member
Author
The only occurence of session manual start I found in plugins (except in tests) are pluginsGLPI/databaseinventory#85 and a few legacy migration scripts that are not even compatible with GLPI 11.0 and are probably unmaintained. Anyway, the result will just be that some files will be created in the default PHP session dir, instead of the GLPI session dir. It should not be an issue. |
stonebuzz
pushed a commit
to pluginsGLPI/databaseinventory
that referenced
this pull request
Oct 10, 2025
* Do not start a session on CRON context see glpi-project/glpi#21383 * changelog * Apply suggestion from @Rom1-B --------- Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
2 tasks done
2 tasks done
Contributor
|
This PR has been is closed and has been automatically locked. Please open a new issue with all requested information for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
It fixes #21380.
Since #20189, the session is no more started on CLI context. The
$_SESSIONvariable is still used, but its content is not saved anyware and just vanishes at the end of the process execution. Therefore, we do not need to change the sessions files path withsession_save_path().