Include every example module in builds and releases - #220
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root Makefile discovers examples through their Makefiles.
httpstatusandtracingwere missing from that list, so normal builds and the Goa release command skipped their module updates and checks.Add the standard generation/lint/test target for
httpstatus. Add a test target fortracing, whose commands use the basic calculator example's generated packages and have no local design to regenerate. The existing root loop now covers all 19 modules without special release commands.Validation:
make -C httpstatuspasses generation, formatting, static analysis, and tests;make -C tracingbuilds and tests both command packages. Generation produces no source diff. The discovered Makefile directories match all 19 directories containinggo.mod.This changes repository build coverage only. Existing application calls, transport behavior, and stored data are unchanged; no migration or coordinated deployment is required.