Skip to content

Filter Source out of plugin-specific regex filter - #2895

Open
mashirochan wants to merge 1 commit into
goatcorp:masterfrom
mashirochan:filter-source-in-filter
Open

mashirochan wants to merge 1 commit into
goatcorp:masterfrom
mashirochan:filter-source-in-filter

Conversation

@mashirochan

Copy link
Copy Markdown

With change, only log entries actually containing the filter content in the message will display:
image

Without change, every single log entry with the plugin internal name/source will display:
image

@mashirochan
mashirochan requested a review from a team as a code owner July 26, 2026 19:48
@mashirochan

Copy link
Copy Markdown
Author

It certainly mostly deals with edge cases, but perhaps a better example were to be if the plugin were InternallyNamed "BatteryBuddy" and I was trying to search through the logs for battery-related entries. Searching "battery" wouldn't help at all with this new filter, because I'd just get (most) every line from the plugin, BatteryBuddy. The plugin filter already filters the logs by plugin, so you'd never want to use the regex filter to see all logs from the plugin!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant