Compiler: Fix MSVC separate heap assert/crash - #1620
Merged
Conversation
Assert triggers on clspvFreeOutputBuildObjs for windows builds due to API call being a static inline declaration. Windows DLL's have separate CRT heaps - free leads to heap boundary issue. Fix is to remove static inline and define routine in the source compiler file (as well as export it). Tests-Passing: oclcts.test_api_enqueue_task (Win32) Change-Id: I168c44131e463b93de75f403ecee6b0ddfd6cbba Signed-off-by: Austin Annestrand <a.annestrand@samsung.com>
annestrand
force-pushed
the
msvcHeapFreeFix
branch
from
July 23, 2026 23:10
ab719b9 to
e85dd60
Compare
rjodinchr
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assert/crash triggers on clspvFreeOutputBuildObjs
for windows builds due to API call being a
static inline declaration. Windows DLL's have
separate CRT heaps - free leads to heap boundary issue.
Fix is to remove static inline and define routine in the source compiler file (as well as export it).
Tests-Passing: oclcts.test_api_enqueue_task (Win32)