Repository navigation
feat(bigtable): support SessionReadModifyWriteRow on the session client #14585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mutianf
wants to merge
11
commits into
googleapis:main
Choose a base branch
from
mutianf:readModifyWrite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,017
−226
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
faa7c1e
feat(bigtable): support SessionReadModifyWriteRow on the session client
mutianf e1fe41d
reformat and clean up comments
mutianf 1e618c9
refactor(bigtable): split ReadModifyWriteRowShim into Inner/Outer fol…
mutianf 372c99e
fix(bigtable): address PR review comments on ReadModifyWriteRow shim
mutianf 9055ffb
fix(bigtable): move RowConverter to Util; implement supports() for CA…
mutianf 2c1c08e
fix(bigtable): address PR review comments on ReadModifyWriteRow
mutianf ae23bb2
refactor(bigtable): extract shouldRouteToSession to UnaryShim, add Ro…
mutianf b1ce8aa
test(bigtable): add unit tests for RowBuilderShim, UnaryShim.shouldRo…
mutianf 772b973
refactor(bigtable): move buildRowFromProto to RowBuilderShim; add Rea…
mutianf e8e1ca1
refactor(bigtable): remove duplicate fallback comments from shim call…
mutianf 4ca4370
refactor(bigtable): merge READ_WRITE session pools for CheckAndMutate…
mutianf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
...bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/compat/WipFeatures.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| /* | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.google.cloud.bigtable.data.v2.internal.compat; | ||
|
|
||
| /** Tracks work-in-progress session-path features that are not yet enabled in production. */ | ||
| public final class WipFeatures { | ||
| // Enable session-path diversion for CheckAndMutateRow once per-method diversion is supported. | ||
| public static final boolean CHECK_AND_MUTATE_ROW_ENABLED = false; | ||
|
|
||
| // Enable session-path diversion for ReadModifyWriteRow once per-method diversion is supported. | ||
| public static final boolean READ_MODIFY_WRITE_ROW_ENABLED = false; | ||
|
|
||
| private WipFeatures() {} | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.