Repository navigation
test(spanner): unflake ITAutogeneratedAdminClientTest - #14603
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds explicit calls to spanner.close() in the grantAndRevokeDatabaseRolePermissions and roleWithNoPermissions integration test methods within ITAutogeneratedAdminClientTest.java to ensure resources are properly cleaned up. There are no review comments, and I have no feedback to provide.
sakthivelmanii
force-pushed
the
unflake-b571071629-pro
branch
2 times, most recently
from
October 8, 2026 15:02
e02953a to
ca05d31
Compare
sakthivelmanii
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This fixes a timeout in roleWithNoPermissions and grantAndRevokeDatabaseRolePermissions where the spanner DatabaseClient instance was not closed before dropping the role, causing the backend DROP ROLE DDL to block on active session pool connections.
sakthivelmanii
force-pushed
the
unflake-b571071629-pro
branch
from
October 8, 2026 15:49
ca05d31 to
5d2b9da
Compare
sakthivelmanii
enabled auto-merge (squash)
October 8, 2026 16:04
olavloite
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a timeout in
roleWithNoPermissionsandgrantAndRevokeDatabaseRolePermissionswhere the SpannerDatabaseClientinstance was not closed before dropping the role, causing the backendDROP ROLEDDL to block on active session pool connections.