Skip to content

chore(build): remove comment from .mvn/maven.config for Maven 3.8 compatibility - #14609

Merged
sakthivelmanii merged 1 commit into
mainfrom
chore-remove-maven-config-comment
Oct 8, 2026
Merged

sakthivelmanii merged 1 commit into
mainfrom
chore-remove-maven-config-comment

Conversation

@sakthivelmanii

Copy link
Copy Markdown
Contributor

Support for '#' comments in .mvn/maven.config was introduced in Apache Maven 3.9.0 (MNG-7682). Prior versions of Maven (such as 3.8.x) and IDE Maven parsers split the entire file on whitespace and reject '#' comment tokens with: Unable to parse maven.config: Unrecognized maven.config entries: [#, TODO:, ...]

Remove the comment line from .mvn/maven.config so that it parses cleanly across both Maven 3.8.x and 3.9+.

…patibility

Support for '#' comments in .mvn/maven.config was introduced in Apache Maven 3.9.0 (MNG-7682). Prior versions of Maven (such as 3.8.x) and IDE Maven parsers split the entire file on whitespace and reject '#' comment tokens with:
Unable to parse maven.config: Unrecognized maven.config entries: [#, TODO:, ...]

Remove the comment line from .mvn/maven.config so that it parses cleanly across both Maven 3.8.x and 3.9+.
@sakthivelmanii
sakthivelmanii requested a review from a team as a code owner October 8, 2026 15:38
@sakthivelmanii
sakthivelmanii enabled auto-merge (squash) October 8, 2026 15:38

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a TODO comment from the .mvn/maven.config file regarding the removal of the file once the flatten-maven-plugin is upgraded. There are no review comments, and I have no feedback to provide.

@sakthivelmanii
sakthivelmanii merged commit 1d92aa5 into main Oct 8, 2026
195 of 196 checks passed
@sakthivelmanii
sakthivelmanii deleted the chore-remove-maven-config-comment branch October 8, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants