Repository navigation
feat(gapic-generator-java): generate javaClientName and javaMethodName in stubs and settings - #14617
jinseopkim0 wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Java GAPIC generator to include the Java client name in the stub settings and the Java method name in the transport call settings. Specifically, it modifies AbstractServiceStubSettingsClassComposer to generate a getJavaClientName() method in stub settings classes, and updates AbstractTransportServiceStubClassComposer to set the Java method name on transport call settings. Additionally, the repository order in assembly.gradle.tmpl is adjusted to prioritize mavenLocal() over mavenCentral(). The remaining changes reflect the regeneration of stubs and settings across various golden files and integration tests. I have no feedback to provide as there are no review comments.
58a3ce0 to
a801089
Compare
…e in stubs and settings
|
@gemini-code-assist review |
a801089 to
c8f751a
Compare
There was a problem hiding this comment.
Code Review
This pull request updates the GAPIC generator for Java to generate the fully qualified Java client name in stub settings and the Java method name in transport call settings, with corresponding updates to showcase and golden files. Additionally, the repository order in the Gradle assembly template was modified. The review feedback correctly points out that placing mavenLocal() before mavenCentral() can degrade build performance and cause non-reproducible builds, recommending that mavenCentral() remain first.
|
|
This branch has not been deployed
1 participant
Updates the Java GAPIC generator to emit
getJavaClientName()in generated[Service]StubSettingsclasses and.setJavaMethodName(...)in generatedGrpc[Service]StubandHttpJson[Service]Stubclasses, and updates unit/integration/Showcase goldens.Depends on #14616.
b/541322523#comment7