Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors resumable upload error handling by removing the upload URL from RewindableStreamBuffer and centralizing exception formatting in ResumableUploadFutureImpl.toTerminalException. It also improves stream cleanup by propagating suppressed exceptions during payload closure. The review feedback highlights two important improvements: adding a null check in toTerminalException to prevent a potential NullPointerException when the input exception is null, and narrowing the caught exception type in closePayload from Throwable to Exception to avoid intercepting critical JVM errors.
f91032c to
95bf1aa
Compare
95bf1aa to
461fc12
Compare
|
|





IOException,IllegalStateException, etc.) are now wrapped inUnknownExceptionwith the original exception asgetCause(), matching GAX's usual convention (results in quite a few updated test assertions).ResumableUploadChunkCoordinatorandonTimeout();toTerminalExceptionnow appends the session URL (when available) at the future boundary.closePayload(@Nullable Throwable)now attaches anypayload.close()failure viaaddSuppressed()instead of swallowing it.